Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on unsigned tinyint (#2649) #2657

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2649

What problem does this PR solve?

Closes #2648

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

Fix a bug that causes TiCDC to panic on an unsigned tinyint

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Aug 27, 2021
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. labels Aug 27, 2021
@amyangfei amyangfei added this to the v5.2.0 milestone Aug 27, 2021
@ti-chi-bot
Copy link
Member Author

@dveeden: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 27, 2021
@amyangfei amyangfei modified the milestones: v5.2.0, v5.2.1 Aug 27, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 1f66cb5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 27, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests

@codecov-commenter
Copy link

Codecov Report

Merging #2657 (1f66cb5) into release-5.2 (81c22b1) will increase coverage by 0.0623%.
The diff coverage is 100.0000%.

@@                 Coverage Diff                 @@
##           release-5.2      #2657        +/-   ##
===================================================
+ Coverage      55.8716%   55.9340%   +0.0623%     
===================================================
  Files              169        169                
  Lines            20667      20669         +2     
===================================================
+ Hits             11547      11561        +14     
+ Misses            8012       8002        -10     
+ Partials          1108       1106         -2     

@ti-chi-bot ti-chi-bot merged commit 647cd36 into pingcap:release-5.2 Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants