Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

owner: fix gc safepoint larger by one #2647

Merged
merged 5 commits into from
Aug 26, 2021
Merged

owner: fix gc safepoint larger by one #2647

merged 5 commits into from
Aug 26, 2021

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Aug 26, 2021

What problem does this PR solve?

What is changed and how it works?

  • Subtract one from GC safepoint.

Check List

Tests

  • Unit test

Code changes

  • Has persistent data change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 26, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • asddongmen

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/cherry-pick-not-approved labels Aug 26, 2021
@liuzix liuzix added the type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR. label Aug 26, 2021
@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 26, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Aug 26, 2021

/run-integration-tests

@amyangfei amyangfei added this to the v5.2.0 milestone Aug 26, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 26, 2021
amyangfei
amyangfei reviewed Aug 26, 2021
View reviewed changes
tests/gc_safepoint/run.sh Outdated Show resolved Hide resolved
tests/gc_safepoint/run.sh Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 26, 2021
@liuzix @amyangfei
Update tests/gc_safepoint/run.sh
0d583ee 
Co-authored-by: amyangfei <amyangfei@gmail.com>
@nongfushanquan nongfushanquan added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Aug 26, 2021
@liuzix @amyangfei
Update tests/gc_safepoint/run.sh
7328315 
Co-authored-by: amyangfei <amyangfei@gmail.com>
@liuzix
Copy link
Contributor Author

liuzix commented Aug 26, 2021

/run-integration-tests

@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7328315

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 26, 2021
@amyangfei
Copy link
Contributor

/merge

@amyangfei
Copy link
Contributor

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-leak-tests

@amyangfei
Copy link
Contributor

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-unit-tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (release-5.2@196112d). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.2      #2647   +/-   ##
================================================
  Coverage               ?   55.8862%           
================================================
  Files                  ?        169           
  Lines                  ?      20667           
  Branches               ?          0           
================================================
  Hits                   ?      11550           
  Misses                 ?       8009           
  Partials               ?       1108

@ti-chi-bot ti-chi-bot merged commit 81c22b1 into pingcap:release-5.2 Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@asddongmen asddongmen asddongmen approved these changes

@lonng lonng Awaiting requested review from lonng

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 This PR is cherry-picked to release-5.2 from a source PR.
Projects
None yet
Milestone
v5.2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@liuzix @ti-chi-bot @amyangfei @codecov-commenter @asddongmen @nongfushanquan