Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add some logs to help debug error. (#2253) #2357

Merged
merged 4 commits into from
Jul 27, 2021
Merged

*: add some logs to help debug error. (#2253) #2357

merged 4 commits into from
Jul 27, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #2253

What problem does this PR solve?

Due to the lack of logs, this issue #2116 are difficult to locate the root cause.
The purpose of the PR is to better locate such problems.

What is changed and how it works?

1.add some log
2.correct some typos

Check List

Tests

  • No code

Code changes

  • None

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

Release note

  • No release note

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 23, 2021
Merged
@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved component/metrics-logging Metrics and logging component. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR. labels Jul 23, 2021
@amyangfei amyangfei added this to the v5.1.1 milestone Jul 26, 2021
@amyangfei
Copy link
Contributor

/merge

@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jul 26, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Jul 26, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 8343b85

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 26, 2021
@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests
/run-kafka-tests

@ti-chi-bot ti-chi-bot merged commit 5a4568b into pingcap:release-5.1 Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei Awaiting requested review from amyangfei

@liuzix liuzix Awaiting requested review from liuzix

Assignees

@asddongmen asddongmen

Labels
cherry-pick-approved Cherry pick PR approved by release team. component/metrics-logging Metrics and logging component. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/cherry-pick-for-release-5.1 This PR is cherry-picked to release-5.1 from a source PR.
Projects
None yet
Milestone
v5.1.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ti-chi-bot @amyangfei @lonng @asddongmen