Skip to content

*: merge new processor related deadlock fixes to 5.0 branch #2142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 25, 2021
Merged

*: merge new processor related deadlock fixes to 5.0 branch #2142

merged 6 commits into from
Jun 25, 2021

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Jun 24, 2021

What problem does this PR solve?

#1987 #2078 #2089 #2085

What is changed and how it works?

  • See the above PRs

Check List

Tests

  • Unit test
  • Integration test

Side effects

  • Increased code complexity

Release note

  • Fix potential deadlocks

@ti-chi-bot ti-chi-bot requested review from amyangfei and zier-one June 24, 2021 03:25
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 24, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Jun 24, 2021

/run-integration-tests

@liuzix liuzix requested a review from overvenus June 24, 2021 03:30
@amyangfei amyangfei added the type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. label Jun 24, 2021
@amyangfei amyangfei added this to the v5.0.3 milestone Jun 24, 2021
@lonng lonng added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Jun 24, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Jun 24, 2021

/run-unit-tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@76bcea0). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #2142   +/-   ##
================================================
  Coverage               ?   53.9449%           
================================================
  Files                  ?        164           
  Lines                  ?      17668           
  Branches               ?          0           
================================================
  Hits                   ?       9531           
  Misses                 ?       7117           
  Partials               ?       1020

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 24, 2021
This was referenced Jun 24, 2021
Closed
Closed
Closed
Closed
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 24, 2021
@overvenus
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2ba0640

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 24, 2021
@amyangfei
Copy link
Contributor

/run-kafka-tests

@lonng
Copy link
Contributor

lonng commented Jun 24, 2021

/merge

@amyangfei
Copy link
Contributor

/run-kafka-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@ti-chi-bot ti-chi-bot merged commit 4ffa335 into pingcap:release-5.0 Jun 25, 2021
@amyangfei amyangfei mentioned this pull request Jun 25, 2021
Closed
liuzix added a commit to liuzix/ticdc that referenced this pull request Jul 6, 2021
@liuzix
*: merge new processor related deadlock fixes to 5.0 branch (pingcap#…
25c0f36 
…2142)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@overvenus overvenus overvenus approved these changes

@zier-one zier-one Awaiting requested review from zier-one

+1 more reviewer

@amyangfei amyangfei amyangfei approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Milestone
v5.0.3
Development

Successfully merging this pull request may close these issues.
6 participants
@liuzix @codecov-commenter @ti-chi-bot @overvenus @amyangfei @lonng