Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owner: Fix owner exit due to emit checkpoint failure (#1985) #2031

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1985

What problem does this PR solve?

#1902

What is changed and how it works?

  • do not return error if send checkpoint message to sink failed, stop the change feed that cause the error instead.
  • fix some typo during walking the code.

Check List

Tests

  • No code

Code changes

Side effects

Related changes

Release note

No release note

@ti-chi-bot
Copy link
Member Author

@ti-chi-bot: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added status/ptal Could you please take a look? release-blocker This issue blocks a release. Please solve it ASAP. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Jun 10, 2021
@amyangfei amyangfei removed the release-blocker This issue blocks a release. Please solve it ASAP. label Jun 10, 2021
@amyangfei amyangfei added this to the v5.0.3 milestone Jun 10, 2021
@3AceShowHand
Copy link
Contributor

/run-all-tests

@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 17, 2021
@3AceShowHand
Copy link
Contributor

/run-all-tests

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-5.0@fc4adf4). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-5.0      #2031   +/-   ##
================================================
  Coverage               ?   54.7511%           
================================================
  Files                  ?        156           
  Lines                  ?      16796           
  Branches               ?          0           
================================================
  Hits                   ?       9196           
  Misses                 ?       6615           
  Partials               ?        985           

@3AceShowHand
Copy link
Contributor

/run-all-tests

@3AceShowHand 3AceShowHand merged commit 70c193e into pingcap:release-5.0 Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/LGT1 Indicates that a PR has LGTM 1. status/ptal Could you please take a look? type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants