Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: sink flow control for old processor #1751

Merged
merged 8 commits into from
May 12, 2021
Merged

*: sink flow control for old processor #1751

merged 8 commits into from
May 12, 2021

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented May 9, 2021

What problem does this PR solve?

  • Lack of flow control in old processor.

What is changed and how it works?

  • Cherry-picked the basic implementation of flow-control to the release branch.
  • Integrated the flow-controller with the old processor.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Possible performance regression
  • Increased code complexity

Related changes

  • Need to update the documentation
  • Need to update key monitor metrics in both TiCDC document and official document

Release note

  • implement processor flow control to avoid OOM.

@liuzix liuzix added the component/replica-model Replication model component. label May 9, 2021
@liuzix liuzix added this to the v4.0.13 milestone May 9, 2021
@ti-chi-bot ti-chi-bot requested review from amyangfei and zier-one May 9, 2021 13:36
@liuzix
Copy link
Contributor Author

liuzix commented May 9, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 9, 2021
@liuzix liuzix force-pushed the zixiong-flow-control-4.0 branch from 98ffeca to 81c31d4 Compare May 9, 2021 13:47
@liuzix
Copy link
Contributor Author

liuzix commented May 9, 2021

/run-all-tests

@liuzix liuzix force-pushed the zixiong-flow-control-4.0 branch from 81c31d4 to e51ff42 Compare May 9, 2021 13:56
@liuzix
Copy link
Contributor Author

liuzix commented May 9, 2021

/run-all-tests

1 similar comment
@liuzix
Copy link
Contributor Author

liuzix commented May 9, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented May 9, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented May 10, 2021

/run-all-tests

@zier-one zier-one added the type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR. label May 10, 2021
@liuzix
Copy link
Contributor Author

liuzix commented May 10, 2021

/run-all-tests

@overvenus
Copy link
Member

Cc #1680.

@liuzix
Copy link
Contributor Author

liuzix commented May 10, 2021

/run-all-tests

2 similar comments
@liuzix
Copy link
Contributor Author

liuzix commented May 11, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented May 12, 2021

/run-all-tests

@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label May 12, 2021
@amyangfei amyangfei added the status/ptal Could you please take a look? label May 12, 2021
@liuzix
Copy link
Contributor Author

liuzix commented May 12, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 12, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • leoppro

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 12, 2021
@amyangfei
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6fe4d64

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label May 12, 2021
@zier-one
Copy link
Contributor

/merge

1 similar comment
@lonng
Copy link
Contributor

lonng commented May 12, 2021

/merge

@ti-chi-bot ti-chi-bot merged commit 2a3e8af into pingcap:release-4.0 May 12, 2021
@amyangfei amyangfei mentioned this pull request May 14, 2021
Closed
@3pointer 3pointer mentioned this pull request May 21, 2021
Merged
10 tasks
liuzix added a commit to liuzix/ticdc that referenced this pull request May 26, 2021
@liuzix
*: sink flow control for old processor (pingcap#1751)
c5560f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@zier-one zier-one zier-one approved these changes

Assignees
No one assigned
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/replica-model Replication model component. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look? type/cherry-pick-for-release-4.0 This PR is cherry-picked to release-4.0 from a source PR.
Projects
None yet
Milestone
v4.0.13
Development

Successfully merging this pull request may close these issues.
7 participants
@liuzix @overvenus @ti-chi-bot @amyangfei @zier-one @lonng @zhouqiang-cl