Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sink: fix avro timezone #1615

Merged
merged 16 commits into from
Apr 27, 2021
Merged

sink: fix avro timezone #1615

merged 16 commits into from
Apr 27, 2021

Conversation

liuzix
Copy link
Contributor

@liuzix liuzix commented Apr 7, 2021 •
edited
Loading

What problem does this PR solve?

What is changed and how it works?

  • Restore timezone information in Avro encoder.

Check List

Tests

  • Unit test

  • Integration test
    Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix time zone lost in Avro output.

@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 7, 2021
@liuzix liuzix added the component/sink Sink component. label Apr 7, 2021
@liuzix liuzix added the bug-from-user Bugs found by users. label Apr 7, 2021
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 7, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Apr 7, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 7, 2021
@liuzix liuzix marked this pull request as ready for review April 8, 2021 11:24
@ti-chi-bot ti-chi-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Apr 8, 2021

/run-all-tests

1 similar comment
@liuzix
Copy link
Contributor Author

liuzix commented Apr 8, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Apr 9, 2021

/run-all-tests

1 similar comment
@liuzix
Copy link
Contributor Author

liuzix commented Apr 9, 2021

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #1615 (8195277) into master (6c41167) will decrease coverage by 0.0087%.
The diff coverage is 50.0000%.

@@               Coverage Diff                @@
##             master      #1615        +/-   ##
================================================
- Coverage   52.9231%   52.9144%   -0.0088%     
================================================
  Files           152        152                
  Lines         16027      16041        +14     
================================================
+ Hits           8482       8488         +6     
- Misses         6646       6655         +9     
+ Partials        899        898         -1

@amyangfei
Copy link
Contributor

Is this PR ready to review?

@liuzix liuzix added the status/ptal Could you please take a look? label Apr 11, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Apr 11, 2021

Is this PR ready to review?

Yes

@amyangfei
Copy link
Contributor

Whether other protocols have this problem, including maxwell, canal, etc. If so, we can file an issue and assign tasks to freshman

@amyangfei amyangfei mentioned this pull request Apr 12, 2021
Open
5 tasks
@amyangfei amyangfei added the needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. label Apr 13, 2021
@liuzix liuzix requested a review from overvenus April 21, 2021 15:31
@liuzix
Copy link
Contributor Author

liuzix commented Apr 21, 2021

@overvenus @leoppro PTAL

@overvenus
Copy link
Member

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • overvenus

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2021
@liuzix
Copy link
Contributor Author

liuzix commented Apr 25, 2021

/run-all-tests

1 similar comment
@liuzix
Copy link
Contributor Author

liuzix commented Apr 25, 2021

/run-all-tests

@liuzix
Copy link
Contributor Author

liuzix commented Apr 25, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4cf67c8

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1615 (31c9078) into master (5946026) will decrease coverage by 0.0305%.
The diff coverage is 52.6315%.

@@               Coverage Diff                @@
##             master      #1615        +/-   ##
================================================
- Coverage   53.8681%   53.8375%   -0.0306%     
================================================
  Files           153        153                
  Lines         16106      16117        +11     
================================================
+ Hits           8676       8677         +1     
- Misses         6520       6527         +7     
- Partials        910        913         +3

@3AceShowHand
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-unit-tests

@amyangfei
Copy link
Contributor

/run-leak-tests

@amyangfei
Copy link
Contributor

/run-unit-tests

@ti-chi-bot ti-chi-bot merged commit 1f1e1aa into pingcap:master Apr 27, 2021
ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Apr 27, 2021
@liuzix @ti-srebot
cherry pick pingcap#1615 to release-4.0
cb4dd8f 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 27, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #1711

ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Apr 27, 2021
@liuzix @ti-srebot
cherry pick pingcap#1615 to release-5.0
b58db6c 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 27, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #1712

amyangfei pushed a commit that referenced this pull request Apr 29, 2021
@ti-srebot
sink: fix avro timezone (#1615) #1711
478fdd8
ti-chi-bot pushed a commit that referenced this pull request May 26, 2021
@ti-srebot
sink: fix avro timezone (#1615) (#1712)
fa8979d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei left review comments

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

@overvenus overvenus Awaiting requested review from overvenus

Assignees
No one assigned
Labels
bug-from-user Bugs found by users. component/sink Sink component. needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.
8 participants
@liuzix @codecov-io @amyangfei @overvenus @ti-chi-bot @codecov-commenter @3AceShowHand @ti-srebot