Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: give http_proxies enough time to bootstrap and use randomized port #1592

Merged
merged 21 commits into from
Apr 27, 2021
Merged

tests: give http_proxies enough time to bootstrap and use randomized port #1592

merged 21 commits into from
Apr 27, 2021

Conversation

YuJuncen
Copy link
Contributor

@YuJuncen YuJuncen commented Mar 31, 2021 •
edited
Loading

What problem does this PR solve?

In bad network environment, http_proxies would fail consistently.

What is changed and how it works?

Give it sometime to bootstrap, use randomized port, or, skip this test.

Check List

Tests

  • Integration test

Release note

  • No release note

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 31, 2021
@YuJuncen
Copy link
Contributor Author

/run-all-tests

@YuJuncen YuJuncen changed the title tests: give http_proxies enough time to bootstrap tests: give http_proxies enough time to bootstrap and use randomized port Mar 31, 2021
@YuJuncen
Copy link
Contributor Author

/run-all-tests

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 1, 2021

/run-all-tests

@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 1, 2021

/run-integration-tests

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2021
@ti-chi-bot ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2021
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 6, 2021

/run-integration-tests

amyangfei
amyangfei reviewed Apr 8, 2021
View reviewed changes
tests/http_proxies/run.sh Outdated Show resolved Hide resolved
@amyangfei amyangfei added status/ptal Could you please take a look? needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. labels Apr 8, 2021
@YuJuncen
Copy link
Contributor Author

YuJuncen commented Apr 9, 2021

/run-integration-tests

@zier-one
Copy link
Contributor

/run-integration-tests

@zier-one
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-all-tests

@amyangfei
Copy link
Contributor

...Again? 🤔

/run-integartion-tests

typo
s/integartion/integration

@codecov-commenter
Copy link

Codecov Report

Merging #1592 (834422f) into master (fd90b40) will increase coverage by 0.1248%.
The diff coverage is 78.1250%.

@@               Coverage Diff                @@
##             master      #1592        +/-   ##
================================================
+ Coverage   53.7122%   53.8370%   +0.1248%     
================================================
  Files           153        153                
  Lines         16082      16106        +24     
================================================
+ Hits           8638       8671        +33     
+ Misses         6534       6524        -10     
- Partials        910        911         +1

@zier-one
Copy link
Contributor

/lgtm

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • amyangfei
  • leoppro

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2021
@zier-one
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 834422f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 25, 2021
@YuJuncen
Copy link
Contributor Author

etcdSuite.TestStreamRecvWithErrorAndResolvedGoBack

/run-leak-test

@YuJuncen
Copy link
Contributor Author

sorterSuite.TestSorterIOError

/run-unit-tests

@YuJuncen
Copy link
Contributor Author

Failed connect to 127.0.0.1:24927; Connection refused 🤔

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-integration-tests

@amyangfei
Copy link
Contributor

/run-leak-tests

@ti-chi-bot ti-chi-bot merged commit 1092578 into pingcap:master Apr 27, 2021
ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Apr 27, 2021
@YuJuncen @ti-srebot
cherry pick pingcap#1592 to release-4.0
8beb683 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 27, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #1713

ti-srebot pushed a commit to ti-srebot/ticdc that referenced this pull request Apr 27, 2021
@YuJuncen @ti-srebot
cherry pick pingcap#1592 to release-5.0
a4ee2fd 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 27, 2021
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #1714

amyangfei pushed a commit to ti-srebot/ticdc that referenced this pull request Apr 28, 2021
@YuJuncen @amyangfei
tests: give http_proxies enough time to bootstrap and use randomized …
26545e4 
…port (pingcap#1592)
amyangfei pushed a commit that referenced this pull request Apr 29, 2021
@ti-srebot
cmd: add log to http proxy environment variables (#1492 & #1592) (#1580)
d9cdab8
ti-chi-bot pushed a commit that referenced this pull request May 27, 2021
@ti-srebot
tests: give http_proxies enough time to bootstrap and use randomized …
ee09a19 
…port (#1592) (#1714)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amyangfei amyangfei amyangfei approved these changes

@lance6716 lance6716 Awaiting requested review from lance6716

Assignees
No one assigned
Labels
needs-cherry-pick-release-4.0 Should cherry pick this PR to release-4.0 branch. needs-cherry-pick-release-5.0 Should cherry pick this PR to release-5.0 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. status/ptal Could you please take a look?
Projects
None yet
Milestone
v5.0.2
Development

Successfully merging this pull request may close these issues.
6 participants
@YuJuncen @zier-one @amyangfei @codecov-commenter @ti-chi-bot @ti-srebot