schema storage: get the schema snap of commit ts -1 to support async commit
#1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-integration-tests |
|
/run-integration-tests |
zier-one
added
the
release-blocker
lysu
added
the
needs-cherry-pick-release-5.0
zier-one
removed
the
needs-cherry-pick-release-5.0
|
/run-integration-tests |
|
/run-kafka-tests |
|
/lgtm |
ti-srebot
approved these changes
Mar 17, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
after pingcap/tidb#23274 , tidb enable async commit by default, and it leads that the commit ts of a DML may be equal with the finished ts of a DDL, and the DML using the schema info before the DDL.
so we should get schema snapshot by
CRTs - 1Check List
Tests
Release note