Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make capture ID accessible through context #150

Merged
merged 1 commit into from
Dec 3, 2019
Merged

Make capture ID accessible through context #150

merged 1 commit into from
Dec 3, 2019

Conversation

suzaku
Copy link
Contributor

@suzaku suzaku commented Dec 2, 2019

What problem does this PR solve?

Deep down in the packages we may need to access information like capture ID.
But we can't pass the capture ID or a capture struct everywhere needed.

What is changed and how it works?

Store capture ID in context so that we have access to it in all scope with the same context.

Check List

Tests

  • Unit test

@suzaku suzaku added status/ptal Could you please take a look? WIP labels Dec 2, 2019
@amyangfei
Copy link
Contributor

/rebuild

@suzaku suzaku removed the WIP label Dec 3, 2019
@suzaku
Copy link
Contributor Author

suzaku commented Dec 3, 2019

@amyangfei Updated.

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added LGT1 and removed status/ptal Could you please take a look? labels Dec 3, 2019
Copy link
Contributor

@zier-one zier-one left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zier-one zier-one added LGT2 and removed LGT1 labels Dec 3, 2019
@suzaku suzaku merged commit 40ed2bf into pingcap:master Dec 3, 2019
@suzaku suzaku deleted the global-capture-id branch December 3, 2019 09:19
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
amyangfei added a commit to amyangfei/tiflow that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants