Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup metrics endpoint for cdc server #144

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Setup metrics endpoint for cdc server #144

merged 2 commits into from
Nov 29, 2019

Conversation

suzaku
Copy link
Contributor

@suzaku suzaku commented Nov 29, 2019

What problem does this PR solve?

Setup metrics endpoint for cdc server

What is changed and how it works?

Check List

Tests

  • Manual test
    Check that the newly added endpoint can be used to access metrics.

@suzaku suzaku added the status/ptal Could you please take a look? label Nov 29, 2019
Copy link
Contributor

@july2993 july2993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

cdc/http_status.go Outdated Show resolved Hide resolved
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added LGT2 and removed status/ptal Could you please take a look? labels Nov 29, 2019
@suzaku suzaku merged commit a5e2825 into pingcap:master Nov 29, 2019
5kbpers pushed a commit to 5kbpers/ticdc that referenced this pull request Aug 24, 2020
* Setup metrics endpoint for cdc server

* Format imports
amyangfei added a commit to amyangfei/tiflow that referenced this pull request May 6, 2022
* add demotask server and client

* remove the temp data files

* fix the make check error

* fix the some errors case

* add the cvs task configure infomation

* add the cvs task configure information

* fix the make check error

* add  the sync progress logic

* refactor the data reader/writer server

* replace the fmt.print with the log and add implement the failover of the cvs jobmaster

* fix  a bug about scan string in kvdatamake.go

* fix the bug in the kvdatamake.go

* remove the blank line in the kvdatamake.go

* refine the cvs task and jobmaster

* remove the cvs jobmaster to the cvs job folder

* fix some bug in the cvs task and cvs jobmaster

* remove useless file

* revert some fixs

* cancel the send method if reach the end of the file

* resolved some review comment

* resolved some review comment

* format the code style

* remove the temp file

* add some logs and fix bugs in the cvs jobmaster

* add the finished case when reading file

* add the pb.go file

Co-authored-by: Zixiong Liu <liuzixiong@pingcap.com>
Co-authored-by: amyangfei <amyangfei@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants