-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup metrics endpoint for cdc server #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
july2993
reviewed
Nov 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
amyangfei
reviewed
Nov 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
amyangfei
approved these changes
Nov 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5kbpers
pushed a commit
to 5kbpers/ticdc
that referenced
this pull request
Aug 24, 2020
* Setup metrics endpoint for cdc server * Format imports
amyangfei
added a commit
to amyangfei/tiflow
that referenced
this pull request
May 6, 2022
* add demotask server and client * remove the temp data files * fix the make check error * fix the some errors case * add the cvs task configure infomation * add the cvs task configure information * fix the make check error * add the sync progress logic * refactor the data reader/writer server * replace the fmt.print with the log and add implement the failover of the cvs jobmaster * fix a bug about scan string in kvdatamake.go * fix the bug in the kvdatamake.go * remove the blank line in the kvdatamake.go * refine the cvs task and jobmaster * remove the cvs jobmaster to the cvs job folder * fix some bug in the cvs task and cvs jobmaster * remove useless file * revert some fixs * cancel the send method if reach the end of the file * resolved some review comment * resolved some review comment * format the code style * remove the temp file * add some logs and fix bugs in the cvs jobmaster * add the finished case when reading file * add the pb.go file Co-authored-by: Zixiong Liu <liuzixiong@pingcap.com> Co-authored-by: amyangfei <amyangfei@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Setup metrics endpoint for cdc server
What is changed and how it works?
Check List
Tests
Check that the newly added endpoint can be used to access metrics.