-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd: enable old value if protocol is maxwell (#1137) #1144
Merged
ti-srebot
merged 4 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-87feaaafa434
Dec 21, 2020
Merged
cmd: enable old value if protocol is maxwell (#1137) #1144
ti-srebot
merged 4 commits into
pingcap:release-4.0
from
ti-srebot:release-4.0-87feaaafa434
Dec 21, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## release-4.0 #1144 +/- ##
================================================
Coverage ? 39.9507%
================================================
Files ? 112
Lines ? 11772
Branches ? 0
================================================
Hits ? 4703
Misses ? 6584
Partials ? 485 |
LGTM |
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
amyangfei
approved these changes
Dec 21, 2020
/merge |
Your auto merge job has been accepted, waiting for:
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/can-merge
Indicates a PR has been approved by a committer.
status/LGT2
Indicates that a PR has LGTM 2.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1137 to release-4.0
What problem does this PR solve?
Optimization for https://github.com/pingcap/ticdc/issues/1109
What is changed and how it works?
Enable old value if protocol is maxwell
Check List
Tests
Release note