Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: enable old value if protocol is maxwell (#1137) #1144

Merged
merged 4 commits into from
Dec 21, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #1137 to release-4.0


What problem does this PR solve?

Optimization for https://github.com/pingcap/ticdc/issues/1109

What is changed and how it works?

Enable old value if protocol is maxwell

Check List

Tests

  • Unit test
  • Integration test

Release note

  • No release note

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

@codecov-io
Copy link

codecov-io commented Nov 30, 2020

Codecov Report

❗ No coverage uploaded for pull request base (release-4.0@05db179). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             release-4.0      #1144   +/-   ##
================================================
  Coverage               ?   39.9507%           
================================================
  Files                  ?        112           
  Lines                  ?      11772           
  Branches               ?          0           
================================================
  Hits                   ?       4703           
  Misses                 ?       6584           
  Partials               ?        485           

@zier-one zier-one modified the milestones: v4.0.9, v4.0.10 Dec 1, 2020
@overvenus
Copy link
Member

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 1, 2020
@amyangfei
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 21, 2020
@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 1136
  • 1141

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Dec 21, 2020
@amyangfei
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

Your auto merge job has been accepted, waiting for:

  • 1164

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 0967be6 into pingcap:release-4.0 Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants