maxwell: fix some bug and refine output #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… old data structure output
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
|
|
No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md |
zier-one
reviewed
Nov 26, 2020
…dreams/ticdc into fix_base64_decode_to_maxwell
liuzix
reviewed
Nov 26, 2020
zier-one
added
type/bugfix
zier-one
reviewed
Nov 30, 2020
zier-one
reviewed
Nov 30, 2020
zier-one
reviewed
Nov 30, 2020
zier-one
reviewed
Dec 1, 2020
cdc/sink/codec/maxwell.go
Outdated
Comment on lines
108
to
119
| switch v.Type { | ||
| case mysql.TypeString, mysql.TypeVarString, mysql.TypeVarchar, mysql.TypeTinyBlob, mysql.TypeMediumBlob, mysql.TypeLongBlob, mysql.TypeBlob: | ||
| if v.Value == nil { | ||
| value.Data[v.Name] = nil | ||
| } else if v.Flag.IsBinary() { | ||
| value.Data[v.Name] = v.Value | ||
| } else { | ||
| value.Data[v.Name] = string(v.Value.([]byte)) | ||
| } | ||
| default: | ||
| value.Data[v.Name] = v.Value | ||
| } |
There was a problem hiding this comment.
could you abstract repetitive logic to a function?
zier-one
changed the title
…dreams/ticdc into fix_base64_decode_to_maxwell
…dreams/ticdc into fix_base64_decode_to_maxwell
zier-one
approved these changes
Dec 7, 2020
|
LGTM |
ti-srebot
approved these changes
Dec 7, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
ti-srebot
pushed a commit
to ti-srebot/ticdc
that referenced
this pull request
Dec 7, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #1173 |
ti-srebot
added a commit
that referenced
this pull request
Dec 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix maxwell base64 data output, fix maxwell output tso to unix timestamp, fix old data structure output
Release note