dm: upgrade go-mysql library (#11043) #11189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
lgtm
release-note
1 task
ti-chi-bot
added
size/XS
ti-chi-bot
added
the
cherry-pick-approved
ti-chi-bot
added
the
cherry-pick-approved
ti-chi-bot
bot
added
size/S
D3Hunter
approved these changes
May 28, 2024
ti-chi-bot
bot
added
size/XS
ti-chi-bot
bot
added
size/M
tangenta
approved these changes
May 28, 2024
D3Hunter
reviewed
May 28, 2024
| @@ -163,7 +163,11 @@ func GTIDIncrease(flavor string, gSet gmysql.GTIDSet) (gmysql.GTIDSet, error) { | |||
| mariaGTID := singleGTID.(*gmysql.MariadbGTID) | |||
| mariaGTID.SequenceNumber++ | |||
| gtidSet := new(gmysql.MariadbGTIDSet) | |||
| gtidSet.Sets = map[uint32]*gmysql.MariadbGTID{mariaGTID.DomainID: mariaGTID} | |||
| gtidSet.Sets = map[uint32]map[uint32]*gmysql.MariadbGTID{ | |||
There was a problem hiding this comment.
this and below part is copied from https://github.com/pingcap/tiflow/pull/10753/files#diff-7d0132544845cb9d5d4fbef67bdd54ba574cc5664f806e49fe1530aefad8cfa2
|
@tangenta: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Benjamin2037, D3Hunter, tangenta The full list of commands accepted by this bot can be found here. The pull request process is described here |
|
/retest |
|
/retest |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #11043
What problem does this PR solve?
Issue Number: close #11041
What is changed and how it works?
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note