Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dm: upgrade go-mysql library (#11043) #11188

Merged
merged 12 commits into from
Jun 13, 2024
Merged

dm: upgrade go-mysql library (#11043) #11188

merged 12 commits into from
Jun 13, 2024

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #11043

What problem does this PR solve?

Issue Number: close #11041

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

upgrade go-mysql to fix the connection blocked when read handshake packet

@D3Hunter @ti-chi-bot
This is an automated cherry-pick of pingcap#11043
60230b1 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels May 28, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request May 28, 2024
Merged
1 task
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label May 28, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2024
@lance6716
fix conflict
8589116 
Signed-off-by: lance6716 <lance6716@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2024
@ti-chi-bot ti-chi-bot bot added the approved label Jun 3, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: D3Hunter, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 3, 2024 •
edited
Loading

the x/exp dependency of parser is outdated, it makes compile fail. to fix it, we need upgrade tidb parser 6.5 to use a newer version of x/exp first.
Note, we cannot upgrade parser to 7.5.x in which we upgrade x/exp, as other library like github.com/chaos-mesh/go-sqlsmith also uses github.com/pingcap/tidb/parser

as the issue described only appears on aurora, and no report from OP users, so i will update this as non-block, and fix it later

user can upgrade to DM 7.5.x as a workaround

@D3Hunter D3Hunter mentioned this pull request Jun 4, 2024
Merged
13 tasks
@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 4, 2024

/hold

wait pingcap/tidb#53785

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 4, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 4, 2024
@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 4, 2024

/retest

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 4, 2024

/retest

@hicqu
Copy link
Contributor

hicqu commented Jun 5, 2024

/test cdc-integration-mysql-test

@hicqu
Copy link
Contributor

hicqu commented Jun 5, 2024

/test cdc-integration-kafka-test

1 similar comment
@hicqu
Copy link
Contributor

hicqu commented Jun 5, 2024

/test cdc-integration-kafka-test

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 5, 2024

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2024
@lance6716
Copy link
Contributor

/retest

@D3Hunter
Copy link
Contributor

D3Hunter commented Jun 6, 2024

/retest

CDC tests always fail, i have ask @hicqu to check it

@D3Hunter
Copy link
Contributor

/retest

1 similar comment
@Ivy-YinSu
Copy link

/retest

@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Jun 12, 2024
@hicqu
Copy link
Contributor

hicqu commented Jun 12, 2024

/retest

@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Jun 12, 2024
@hicqu
Copy link
Contributor

hicqu commented Jun 12, 2024

/retest

@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 12, 2024
@hicqu hicqu force-pushed the cherry-pick-11043-to-release-6.5 branch from a3d30ca to 2f87c71 Compare June 12, 2024 11:57
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 12, 2024
@hicqu
fix
89f4d27 
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu
fix
ff3a60b 
Signed-off-by: qupeng <qupeng@pingcap.com>
@hicqu hicqu force-pushed the cherry-pick-11043-to-release-6.5 branch from 43bae90 to ff3a60b Compare June 13, 2024 05:29
@hicqu
Copy link
Contributor

hicqu commented Jun 13, 2024

/test verify

@ti-chi-bot ti-chi-bot bot merged commit 66d7a1c into pingcap:release-6.5 Jun 13, 2024
10 checks passed
@hicqu hicqu deleted the cherry-pick-11043-to-release-6.5 branch June 13, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@D3Hunter D3Hunter D3Hunter approved these changes

Assignees

@D3Hunter D3Hunter

Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ti-chi-bot @D3Hunter @hicqu @lance6716 @Ivy-YinSu