Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kvclient(ticdc): close the grpc client after all goroutine exited to prevent data race and panic (#10865) #10906

Merged
merged 5 commits into from
Apr 16, 2024
Merged

kvclient(ticdc): close the grpc client after all goroutine exited to prevent data race and panic (#10865) #10906

merged 5 commits into from
Apr 16, 2024

Commits on Apr 15, 2024

  1. use errgroup to control grpc stream.

    @3AceShowHand @ti-chi-bot
    3AceShowHand authored and ti-chi-bot committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    31925f6 View commit details
    Browse the repository at this point in the history

  2. remove set nil.

    @3AceShowHand @ti-chi-bot
    3AceShowHand authored and ti-chi-bot committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    f349002 View commit details
    Browse the repository at this point in the history

  3. use atomic bool to control close the grpc stream once

    @3AceShowHand @ti-chi-bot
    3AceShowHand authored and ti-chi-bot committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    aff1592 View commit details
    Browse the repository at this point in the history

  4. add some comment.

    @3AceShowHand @ti-chi-bot
    3AceShowHand authored and ti-chi-bot committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    fb4113a View commit details
    Browse the repository at this point in the history

  5. fix big txn integration test.

    @3AceShowHand @ti-chi-bot
    3AceShowHand authored and ti-chi-bot committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    56f63c6 View commit details
    Browse the repository at this point in the history