Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codec(ticdc): add more logs to the avro encoding to help detect potential key encoding failed issure #10901

Merged
merged 3 commits into from
Apr 28, 2024
Merged

codec(ticdc): add more logs to the avro encoding to help detect potential key encoding failed issure #10901

merged 3 commits into from
Apr 28, 2024

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #10774

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-triage-completed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 11, 2024
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 11, 2024
@3AceShowHand
Copy link
Contributor Author

/check-issue-triage-complete

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Apr 11, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 57.8055%. Comparing base (344a5d8) to head (bdd4573).
Report is 8 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 62.3253% <0.0000%> (+0.6440%) ⬆️
dm 51.4129% <ø> (+0.1816%) ⬆️
engine 63.4585% <ø> (+0.0706%) ⬆️
Flag Coverage Δ
unit 57.8055% <0.0000%> (+0.4153%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10901        +/-   ##
================================================
+ Coverage   57.3902%   57.8055%   +0.4153%     
================================================
  Files           851        851                
  Lines        125145     126045       +900     
================================================
+ Hits          71821      72861      +1040     
+ Misses        47929      47800       -129     
+ Partials       5395       5384        -11

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 11, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-11 03:42:14.656812871 +0000 UTC m=+1106596.184353415: ☑️ agreed by asddongmen.
  • 2024-04-11 08:06:51.946403377 +0000 UTC m=+1122473.473943923: ☑️ agreed by CharlesCheung96.

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/check-issue-triage-complete

@3AceShowHand
Copy link
Contributor Author

/retest

9 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand 3AceShowHand added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. labels Apr 24, 2024
@3AceShowHand
Copy link
Contributor Author

/retest

7 similar comments
@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@3AceShowHand
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit ba6db07 into pingcap:master Apr 28, 2024
27 of 28 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #10999.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Apr 28, 2024
@3AceShowHand @ti-chi-bot
This is an automated cherry-pick of pingcap#10901
4268a83 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Apr 28, 2024
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11000.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 28, 2024
Merged
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.0: #11001.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 28, 2024
Open
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #11002.

@ti-chi-bot ti-chi-bot mentioned this pull request Apr 28, 2024
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Apr 30, 2024
@ti-chi-bot
codec(ticdc): add more logs to the avro encoding to help detect poten…
c78adb6 
…tial key encoding failed issure (#10901) (#11002)

close #10774
ti-chi-bot bot pushed a commit that referenced this pull request May 10, 2024
@ti-chi-bot
codec(ticdc): add more logs to the avro encoding to help detect poten…
a4962cd 
…tial key encoding failed issure (#10901) (#11000)

close #10774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asddongmen asddongmen asddongmen approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@flowbehappy flowbehappy Awaiting requested review from flowbehappy

@hongyunyan hongyunyan Awaiting requested review from hongyunyan

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.0 Should cherry pick this PR to release-8.0 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

avro protocol: key converting to Avro binary failed
4 participants
@3AceShowHand @ti-chi-bot @asddongmen @CharlesCheung96