-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ticdc: fix update calls to runtime.fastrand to use cheaprand for compatibility with Go 1.22 #10755
base: master
Are you sure you want to change the base?
Conversation
…atibility with Go 1.22 In Golang 1.22, the `runtime.fastrand` method was renamed to `cheaprand`. This commit updates all occurrences of `runtime.fastrand` in the project to use the new `cheaprand` method to maintain compatibility with the latest Golang version and address performance concerns. Refer: https://gist.github.com/Aoang/3dc06f127f3f54507b7e06b7b6550c28
[FORMAT CHECKER NOTIFICATION] Notice: To remove the 📖 For more info, you can check the "Contribute Code" section in the development guide. |
Welcome @Aoang! |
Hi @Aoang. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[LGTM Timeline notifier]Timeline:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #10755 +/- ##
================================================
- Coverage 57.5449% 57.5311% -0.0138%
================================================
Files 853 853
Lines 126807 126886 +79
================================================
+ Hits 72971 72999 +28
- Misses 48393 48448 +55
+ Partials 5443 5439 -4 |
@Aoang: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: 3AceShowHand, CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix update calls to runtime.fastrand to use cheaprand for compatibility with Go 1.22
In Golang 1.22, the
runtime.fastrand
method was renamed tocheaprand
. This commit updates all occurrences ofruntime.fastrand
in the project to use the newcheaprand
method to maintain compatibility with the latest Golang version and address performance concerns.Refer: https://gist.github.com/Aoang/3dc06f127f3f54507b7e06b7b6550c28
What problem does this PR solve?
Issue Number: close #xxx
What is changed and how it works?
Check List
Tests
Questions
None
Will it cause performance regression or break compatibility?
None
Do you need to update user documentation, design documentation or monitoring documentation?
None
Release note
None