Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a case of Mariadb for dm_upstream_switch #10735

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

okJiang
Copy link
Member

@okJiang okJiang commented Mar 7, 2024

What problem does this PR solve?

Issue Number: close #10734, close #10733

What is changed and how it works?

  • Add DM_MASTER_EXTRA_ARG to dm_upstream_switch case
  • Add Mariadb dm_upstream_switch case(copy from MySQL&&fix some compatible problems)
  • FYI, Mariadb vs MySQL in gtid replication
    • need set gtid_domain_id
    • gtid mode is gtid_strict_mode
    • change master to need set master_use_gtid=slave_pos

Check List

Tests

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

`None`.

Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from okjiang, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 7, 2024
@okJiang okJiang requested review from GMHDBJD and lance6716 March 7, 2024 03:38
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.5465%. Comparing base (f9ca8a2) to head (4095590).
Report is 292 commits behind head on master.

Additional details and impacted files
Components Coverage Δ
cdc 61.9406% <ø> (+0.0174%) ⬆️
dm 51.1950% <ø> (+0.0080%) ⬆️
engine 63.2805% <ø> (-0.0636%) ⬇️
Flag Coverage Δ
unit 57.5465% <ø> (+0.0053%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10735        +/-   ##
================================================
+ Coverage   57.5412%   57.5465%   +0.0053%     
================================================
  Files           850        851         +1     
  Lines        126770     126793        +23     
================================================
+ Hits          72945      72965        +20     
  Misses        48384      48384                
- Partials       5441       5444         +3     

@okJiang
Copy link
Member Author

okJiang commented Mar 7, 2024

/retest

- name: Slack notification
if: ${{ failure() }}
env:
SLACK_WEBHOOK: ${{ secrets.SLACK_NOTIFY }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no one use slack now, could we use feishu instead

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll delete them first
image

@@ -0,0 +1,25 @@
vrrp_script chk_mysql_port {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the folder name need change

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we combine it with upstream_swith? e.g. we only need add mariadb pod in original docker file, and add new case in original case.sh

@okJiang
Copy link
Member Author

okJiang commented Mar 8, 2024

can we combine it with upstream_swith? e.g. we only need add mariadb pod in original docker file, and add new case in original case.sh

Solving this problem #10741 later may require modifying the case. If there is no need to modify it, I will merge it together.

@asddongmen
Copy link
Contributor

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mariadb need the test case dm_upstream_switch too test: dm_upstream_switch doesn't work
3 participants