-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add a case of Mariadb for dm_upstream_switch #10735
base: master
Are you sure you want to change the base?
Conversation
***Update Dockerfile for mysql image in upstream_switch*** ***Remove unnecessary lines in Dockerfile for upstream_switch_mariadb
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #10735 +/- ##
================================================
+ Coverage 57.5412% 57.5465% +0.0053%
================================================
Files 850 851 +1
Lines 126770 126793 +23
================================================
+ Hits 72945 72965 +20
Misses 48384 48384
- Partials 5441 5444 +3 |
/retest |
- name: Slack notification | ||
if: ${{ failure() }} | ||
env: | ||
SLACK_WEBHOOK: ${{ secrets.SLACK_NOTIFY }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no one use slack now, could we use feishu instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,25 @@ | |||
vrrp_script chk_mysql_port { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the folder name need change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we combine it with upstream_swith? e.g. we only need add mariadb pod in original docker file, and add new case in original case.sh
Solving this problem #10741 later may require modifying the case. If there is no need to modify it, I will merge it together. |
/retest |
What problem does this PR solve?
Issue Number: close #10734, close #10733
What is changed and how it works?
gtid_domain_id
gtid_strict_mode
master_use_gtid=slave_pos
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note