Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli(ticdc): fix create changefeed failure when enable-old-value is set to true #10731

Closed
wants to merge 11 commits into from

Conversation

lidezhu
Copy link
Collaborator

@lidezhu lidezhu commented Mar 6, 2024

What problem does this PR solve?

Issue Number: close #10711

What is changed and how it works?

Report a warning and ignore the config when enable-old-value is set to true.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
  1. create changefeed with config file which set enable-old-value to true and see whether changefeed can be created successfully and whether the warning is printed as expected.

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 3aceshowhand for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 6, 2024
@lidezhu
Copy link
Collaborator Author

lidezhu commented Mar 6, 2024

/label needs-cherry-pick-release-7.5

@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Mar 6, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #10731 (23ac6ec) into master (f9ca8a2) will increase coverage by 0.0302%.
Report is 2 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
Components Coverage Δ
cdc 61.9475% <100.0000%> (+0.0243%) ⬆️
dm 51.2273% <ø> (+0.0404%) ⬆️
engine 63.3582% <ø> (+0.0141%) ⬆️
Flag Coverage Δ
unit 57.5714% <100.0000%> (+0.0302%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10731        +/-   ##
================================================
+ Coverage   57.5412%   57.5714%   +0.0302%     
================================================
  Files           850        851         +1     
  Lines        126770     126799        +29     
================================================
+ Hits          72945      73000        +55     
+ Misses        48384      48363        -21     
+ Partials       5441       5436         -5     

@lidezhu
Copy link
Collaborator Author

lidezhu commented Mar 7, 2024

/test cdc-integration-kafka-test

@flowbehappy flowbehappy added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 7, 2024
@flowbehappy
Copy link
Collaborator

The same issue has been address by this issue #10916. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CDC] Create changefeed failed when config the parameter enable-old-value
2 participants