-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli(ticdc): fix create changefeed failure when enable-old-value
is set to true
#10731
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/label needs-cherry-pick-release-7.5 |
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #10731 +/- ##
================================================
+ Coverage 57.5412% 57.5714% +0.0302%
================================================
Files 850 851 +1
Lines 126770 126799 +29
================================================
+ Hits 72945 73000 +55
+ Misses 48384 48363 -21
+ Partials 5441 5436 -5 |
/test cdc-integration-kafka-test |
The same issue has been address by this issue #10916. Closing this PR. |
What problem does this PR solve?
Issue Number: close #10711
What is changed and how it works?
Report a warning and ignore the config when
enable-old-value
is set to true.Check List
Tests
enable-old-value
to true and see whether changefeed can be created successfully and whether the warning is printed as expected.Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note