Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple (ticdc): fix simple rename table ddl handle error #10687

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

asddongmen
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #9898

What is changed and how it works?

After a rename table ddl happens, the tableStatistic of the table in bootstraper should be updated.

Check List

Tests

  • Unit test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Mar 1, 2024
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 1, 2024
@asddongmen asddongmen self-assigned this Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Merging #10687 (6743aaf) into master (c178273) will increase coverage by 0.2074%.
Report is 12 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
Components Coverage Δ
cdc 62.3503% <100.0000%> (+0.2607%) ⬆️
dm 51.3836% <ø> (+0.1570%) ⬆️
engine 63.3060% <ø> (-0.1037%) ⬇️
Flag Coverage Δ
unit 57.8446% <100.0000%> (+0.2074%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #10687        +/-   ##
================================================
+ Coverage   57.6371%   57.8446%   +0.2074%     
================================================
  Files           849        850         +1     
  Lines        126519     127578      +1059     
================================================
+ Hits          72922      73797       +875     
- Misses        48156      48334       +178     
- Partials       5441       5447         +6     

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Mar 1, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Mar 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-01 02:40:43.383211468 +0000 UTC m=+1188932.130834574: ☑️ agreed by 3AceShowHand.
  • 2024-03-05 03:56:16.661326173 +0000 UTC m=+139403.683572561: ☑️ agreed by CharlesCheung96.

@asddongmen
Copy link
Contributor Author

/retest

3 similar comments
@asddongmen
Copy link
Contributor Author

/retest

@asddongmen
Copy link
Contributor Author

/retest

@asddongmen
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit 06fcdc5 into pingcap:master Mar 6, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants