Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulsar (ticdc): add integration test for pulsar + ssl and oauth2 #10622

Closed

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Feb 20, 2024

What problem does this PR solve?

Issue Number: ref #10602

What is changed and how it works?

  1. Enable the Pulsar consumer to consume messages from a TLS and OAuth 2.0 enabled Pulsar server.
  2. Include self-signed certificates and keys to enable Pulsar + SSL and OAuth 2.0 integration testing.
  3. Ensure that the existing Pulsar sink integration test cases can be executed with SSL and OAuth 2.0 enabled.

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

Copy link
Contributor

ti-chi-bot bot commented Feb 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 20, 2024
Copy link
Contributor

ti-chi-bot bot commented Feb 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from asddongmen. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 20, 2024
@asddongmen asddongmen changed the title pulsar/logger: ensure the .With*() fields are logged pulsar (ticdc): add integration for pulsar + ssl and oauth2 Feb 20, 2024
@asddongmen asddongmen changed the title pulsar (ticdc): add integration for pulsar + ssl and oauth2 pulsar (ticdc): add integration test for pulsar + ssl and oauth2 Feb 20, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Feb 21, 2024
@asddongmen asddongmen closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affect-ticdc-config-docs Pull requests that affect TiCDC configuration docs. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants