-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cdc: fix build table info #10492
cdc: fix build table info #10492
Conversation
93d17af
to
1a790ea
Compare
851e6d5
to
78e9138
Compare
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. @@ Coverage Diff @@
## master #10492 +/- ##
================================================
+ Coverage 57.4123% 57.4750% +0.0626%
================================================
Files 849 849
Lines 125858 125973 +115
================================================
+ Hits 72258 72403 +145
+ Misses 48193 48159 -34
- Partials 5407 5411 +4 |
/test cdc-integration-kafka-test |
/retest |
Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com>
Co-authored-by: dongmen <20351731+asddongmen@users.noreply.github.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: asddongmen, CharlesCheung96 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
/retest |
What problem does this PR solve?
Issue Number: ref #10386
What is changed and how it works?
Fix and improve
BuildTiDBTableInfo
;Fix the wrong behavior that a primary column is always set an extra unique key flag in
WrapTableInfo
;Add some helper method on
TableInfo
to query related information for columns;Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note