Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl (ticdc): support replicate ddl in BDR mode #10299

Merged
merged 19 commits into from
Jan 5, 2024
Merged

ddl (ticdc): support replicate ddl in BDR mode #10299

merged 19 commits into from
Jan 5, 2024

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Dec 14, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #10301

What is changed and how it works?

Only replicate DDL with BDRRolePrimary as the role in BDR mode changefeed.

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Please take a look at the newly added integration test case.

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

Support replicate ddl in BDR mode.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 14, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 14, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 15, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Dec 19, 2023
@asddongmen asddongmen changed the title [WIP] ddl (ticdc): support replicate ddl in BDR mode ddl (ticdc): support replicate ddl in BDR mode Dec 19, 2023
@asddongmen asddongmen removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 29, 2023
@asddongmen asddongmen marked this pull request as ready for review December 29, 2023 07:45
@asddongmen
Copy link
Contributor Author

/retest

@asddongmen
Copy link
Contributor Author

/retest

2 similar comments
@asddongmen
Copy link
Contributor Author

/retest

@asddongmen
Copy link
Contributor Author

/retest

@asddongmen
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jan 4, 2024
@asddongmen
Copy link
Contributor Author

/retst

@asddongmen
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 4, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3AceShowHand, CharlesCheung96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [3AceShowHand,CharlesCheung96]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jan 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-04 03:28:39.412070776 +0000 UTC m=+2314010.449297702: ☑️ agreed by 3AceShowHand.
  • 2024-01-04 07:41:10.839800264 +0000 UTC m=+2329161.877027192: ☑️ agreed by CharlesCheung96.

asddongmen and others added 2 commits January 4, 2024 15:58
@asddongmen
Resolve comment
6fcdea0
@lance6716
update tidb dep
b04654f 
Signed-off-by: lance6716 <lance6716@gmail.com>
@asddongmen
Copy link
Contributor Author

/retest

@okJiang okJiang mentioned this pull request Jan 5, 2024
Closed
6 tasks
@asddongmen
Copy link
Contributor Author

/retest

3 similar comments
@asddongmen
Copy link
Contributor Author

/retest

@asddongmen
Copy link
Contributor Author

/retest

@asddongmen
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit f80995c into pingcap:master Jan 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3AceShowHand 3AceShowHand 3AceShowHand approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@sdojjy sdojjy Awaiting requested review from sdojjy

Assignees
No one assigned
Labels
approved lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make TiCDC support replicating DDL in BDR mode.
5 participants
@asddongmen @okJiang @3AceShowHand @CharlesCheung96 @lance6716