Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codec(ticdc): simple protocol DDL message encode 2 table schema #10294

Merged
merged 18 commits into from
Dec 20, 2023
Merged

codec(ticdc): simple protocol DDL message encode 2 table schema #10294

merged 18 commits into from
Dec 20, 2023

Conversation

3AceShowHand
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #10293

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note 

`None`

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 13, 2023
@asddongmen asddongmen self-requested a review December 13, 2023 09:16
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 19, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 19, 2023
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/needs-triage-completed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 19, 2023
CharlesCheung96
CharlesCheung96 reviewed Dec 19, 2023
View reviewed changes
pkg/sink/codec/simple/message.go
table = ddl.TableInfo.TableName.Table
schemaVersion = ddl.TableInfo.UpdateTS
}
if !ddl.IsBootstrap {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IsBootstrap should be removed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be removed in the next PR which is to support sending bootstrap at the processor side.

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 20, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-19 07:28:10.249295643 +0000 UTC m=+945981.286522562: ☑️ agreed by asddongmen.
  • 2023-12-20 06:49:32.346263981 +0000 UTC m=+1030063.383490909: ☑️ agreed by CharlesCheung96.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, CharlesCheung96, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,asddongmen,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

@3AceShowHand: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test cdc-integration-kafka-test
  • /test cdc-integration-mysql-test
  • /test cdc-integration-pulsar-test
  • /test cdc-integration-storage-test
  • /test dm-compatibility-test
  • /test dm-integration-test
  • /test engine-integration-test
  • /test verify
  • /test wip-pull-build
  • /test wip-pull-check
  • /test wip-pull-unit-test-cdc
  • /test wip-pull-unit-test-dm
  • /test wip-pull-unit-test-engine

Use /test all to run the following jobs that were automatically triggered:

  • pingcap/tiflow/ghpr_verify
  • pingcap/tiflow/pull_cdc_integration_kafka_test
  • pingcap/tiflow/pull_cdc_integration_storage_test
  • pingcap/tiflow/pull_cdc_integration_test
  • pingcap/tiflow/pull_dm_compatibility_test
  • pingcap/tiflow/pull_dm_integration_test
  • pingcap/tiflow/pull_engine_integration_test

In response to this:

/test dm-integration-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@3AceShowHand
Copy link
Contributor Author

/test dm-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 964df36 into pingcap:master Dec 20, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdojjy sdojjy sdojjy approved these changes

@CharlesCheung96 CharlesCheung96 CharlesCheung96 approved these changes

@asddongmen asddongmen Awaiting requested review from asddongmen

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DDL message carries 2 schemas
4 participants
@3AceShowHand @sdojjy @asddongmen @CharlesCheung96