Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syncer(dm): Improve logging of ignored TableMap/FormatDesc #10205

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Nov 30, 2023

What problem does this PR solve?

Issue Number: close #10204

What is changed and how it works?

This makes the logging on the warning level less noisy and adds detail to the TableMap event logs.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Logging of `TableMapEvent` and `FormatDescriptionEvent` was changed from the warning level to the info level.

@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 30, 2023
@dveeden
Copy link
Contributor Author

dveeden commented Nov 30, 2023

/cc @lance6716

@ti-chi-bot ti-chi-bot bot requested a review from lance6716 November 30, 2023 12:14
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 30, 2023
dm/syncer/syncer.go Outdated Show resolved Hide resolved
@lance6716 lance6716 changed the title Improve logging of ignored TableMap/FormatDesc syncer(dm): Improve logging of ignored TableMap/FormatDesc Dec 1, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2023
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 1, 2023
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Dec 1, 2023
@lance6716
Copy link
Contributor

/cc @lichunzhu @okJiang

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 4, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 4, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 4, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-01 10:31:53.916640115 +0000 UTC m=+1177942.581866310: ☑️ agreed by lance6716.
  • 2023-12-04 03:19:41.80756093 +0000 UTC m=+1411210.472787125: ☑️ agreed by okJiang.

@dveeden
Copy link
Contributor Author

dveeden commented Dec 4, 2023

/retest

2 similar comments
@dveeden
Copy link
Contributor Author

dveeden commented Dec 4, 2023

/retest

@lance6716
Copy link
Contributor

/retest

@ti-chi-bot ti-chi-bot bot merged commit 1fa2752 into pingcap:master Dec 4, 2023
14 checks passed
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label Oct 15, 2024
@ti-chi-bot ti-chi-bot bot added needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. labels Oct 15, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #11659.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #11660.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Oct 15, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Oct 15, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #11661.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Oct 15, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #11662.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #11663.

ti-chi-bot pushed a commit to ti-chi-bot/tiflow that referenced this pull request Oct 15, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logging of FormatDesc and TableMap doesn't need to be a warning
4 participants