sink(cdc): always handle sink failures for cases with sync-point enabled (#10132) #10140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
ti-chi-bot
added
lgtm
release-note-none
ti-chi-bot
added
the
cherry-pick-approved
Signed-off-by: qupeng <qupeng@pingcap.com>
hicqu
approved these changes
Nov 24, 2023
hicqu
approved these changes
Nov 24, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hicqu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #10132
What problem does this PR solve?
Issue Number: close #10091
What is changed and how it works?
In
SinkManager, suppose there is a table withcheckpointTs=100andlastWrittenPos=110, and sync-point is also110.And then, the sink backend fails, the sink should be re-started at
100.However, when generating sink tasks,
SinkManagerfinds the table has no more available events afterlastWrittenPos=110, and it can't detect the sink backend failure any more.With the PR this behavior is corrected.
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note