Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove check of utf8mb4_0900_ai_ci as tidb now support it #9610

Closed
D3Hunter opened this issue Aug 18, 2023 · 0 comments · Fixed by #9611
Closed

remove check of utf8mb4_0900_ai_ci as tidb now support it #9610

D3Hunter opened this issue Aug 18, 2023 · 0 comments · Fixed by #9611
Labels
area/dm Issues or PRs related to DM. component/test Unit tests and integration tests component. type/enhancement The issue or PR belongs to an enhancement.

Comments

@D3Hunter
Copy link
Contributor

D3Hunter commented Aug 18, 2023 •
edited
Loading

dm integration test sync_collation checks Unsupported collation when new collation is enabled: 'utf8mb4_0900_ai_ci', but this feature is supported. see pingcap/tidb#45650. we should remove this check
@D3Hunter D3Hunter added component/test Unit tests and integration tests component. area/dm Issues or PRs related to DM. labels Aug 18, 2023
@D3Hunter D3Hunter mentioned this issue Aug 18, 2023
Merged
1 task
@D3Hunter D3Hunter added the type/enhancement The issue or PR belongs to an enhancement. label Aug 18, 2023
ti-chi-bot bot pushed a commit that referenced this issue Aug 18, 2023
@D3Hunter
test(dm): fix integration test about utf8mb4_0900_ai_ci (#9611)
f3984a5 
close #9610
3AceShowHand pushed a commit to 3AceShowHand/tiflow that referenced this issue Aug 29, 2023
@D3Hunter @3AceShowHand
test(dm): fix integration test about utf8mb4_0900_ai_ci (pingcap#9611)
2d58db1 
close pingcap#9610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/dm Issues or PRs related to DM. component/test Unit tests and integration tests component. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(dm): fix integration test about utf8mb4_0900_ai_ci pingcap/tiflow
1 participant
@D3Hunter