Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ticdc openapi does not validate Chinese characters for parameter sink.csv.delimiter. #9609

Closed
cchenkey opened this issue Aug 18, 2023 · 2 comments · Fixed by #9785
Closed
Assignees
Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.

Comments

@cchenkey
Copy link

cchenkey commented Aug 18, 2023

What did you do?

use ticdc changefeed openapi update changefeed,when specify parameter sink.csv.delimiter Chinese characters,cdc server also accept it
image

What did you expect to see?

for doc,cdc server will refuse the update requet for it is not an ASCII characters

What did you see instead?

cdc server also accept ther request,i dont know whether it makes work

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

v7.2.0,maybe all versions do not check it
@cchenkey cchenkey added area/ticdc Issues or PRs related to TiCDC. type/bug The issue is confirmed as a bug. labels Aug 18, 2023
@nongfushanquan
Copy link
Contributor

/assign @CharlesCheung96

@fubinzh
Copy link

fubinzh commented Sep 4, 2023

/severity moderate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. severity/moderate type/bug The issue is confirmed as a bug.
Projects
Development

Successfully merging a pull request may close this issue.

4 participants