TiCDC mysql sink can not connect to ipv6 address

[overvenus]

What did you do?

Create a changefeed that replicate data to an ipv6 address MySQL server.

tiup cdc cli changefeed create --pd="http://[::1]:2379" --sink-uri="tidb://root:@[::1]:4005/" --changefeed-id="simple-replication-task" --sort-engine="unified" 

tiflow/cdc/sink/mysql/mysql.go

Line 109 in ee4e36c

dsnStr := fmt.Sprintf("%s:%s@tcp(%s:%s)/%s", username, password, hostName, port, params.tls)

We should use net.JoinHostPort for hostnames that are in literal IP addresses.

Workaround: use DNS domain name.

What did you expect to see?

Success.

What did you see instead?

Starting component cdc: /Users/.tiup/components/cdc/v6.1.0/cdc cli changefeed create --pd=http://[::1]:2379 --sink-uri=tidb://root:@[::1]:4005/ --changefeed-id=simple-replication-task --sort-engine=unified
Error: [CDC:ErrMySQLConnectionError]fail to open MySQL connection: dial tcp [::1:4005]:3306: connect: no route to host

Versions of the cluster

TiCDC version (execute cdc version):

v6.1.0

[lance6716]

please also consider fixing DM's usage

tiflow/dm/pkg/conn/basedb.go

Line 62 in ee4e36c

dsn := fmt.Sprintf("%s:%s@tcp(%s:%d)/?charset=utf8mb4&interpolateParams=true&maxAllowedPacket=0",

[3pointer]

sync-diff & tidb-binlog may also have the problem.
https://github.com/pingcap/tidb-tools/blob/b3ea358e374a64f19258dc21d880e7ec07342366/pkg/dbutil/common.go#L118

[Rustin170506]

please also consider fixing DM's usage

tiflow/dm/pkg/conn/basedb.go

Line 62 in ee4e36c

dsn := fmt.Sprintf("%s:%s@tcp(%s:%d)/?charset=utf8mb4&interpolateParams=true&maxAllowedPacket=0",

The problem with dm might be that the user might pass ::1 instead of [::1], right?

[lance6716]

please also consider fixing DM's usage

tiflow/dm/pkg/conn/basedb.go

Line 62 in ee4e36c

dsn := fmt.Sprintf("%s:%s@tcp(%s:%d)/?charset=utf8mb4&interpolateParams=true&maxAllowedPacket=0",

The problem with dm might be that the user might pass ::1 instead of [::1], right?

Maybe DM should support both type, I haven't take a look at IPv6 address format 😂

[Rustin170506]

please also consider fixing DM's usage

tiflow/dm/pkg/conn/basedb.go

Line 62 in ee4e36c

dsn := fmt.Sprintf("%s:%s@tcp(%s:%d)/?charset=utf8mb4&interpolateParams=true&maxAllowedPacket=0",

The problem with dm might be that the user might pass ::1 instead of [::1], right?

Maybe DM should support both type, I haven't take a look at IPv6 address format 😂

::1 is not a valid address in DSN, but [::1] is.