Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codec(ticdc): wrong serialized value for avro codec when there are multiple decimals with different precision/scale #5554

Closed
zhangyangyu opened this issue May 24, 2022 · 0 comments · Fixed by #5556
Closed

codec(ticdc): wrong serialized value for avro codec when there are multiple decimals with different precision/scale #5554

zhangyangyu opened this issue May 24, 2022 · 0 comments · Fixed by #5556
Labels
affects-6.1 area/ticdc Issues or PRs related to TiCDC. severity/major type/bug The issue is confirmed as a bug.

Comments

@zhangyangyu
Copy link
Member

zhangyangyu commented May 24, 2022 •
edited
Loading

What did you do?

Just as title said. You could use TPC-C test to reproduce. For TPC-C customer table, the c_discount value is always out-of-sync for source and sink.

This raises from bug in goavro, see linkedin/goavro#195.

What did you expect to see?

decimals values are same in source and sink.

What did you see instead?

decimals values are different in source and sink.

Versions of the cluster

Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

(paste TiDB cluster version here)

Upstream TiKV version (execute tikv-server --version):

(paste TiKV version here)

TiCDC version (execute cdc version):

(paste TiCDC version here)
@zhangyangyu zhangyangyu added type/bug The issue is confirmed as a bug. area/ticdc Issues or PRs related to TiCDC. affects-6.1 labels May 24, 2022
@zhangyangyu zhangyangyu mentioned this issue May 24, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue May 24, 2022
@zhangyangyu
codec(ticdc): update goavro to 2.11.1 to solve avro decimal encoding …
745d924 
…bug (#5556)

close #5554
@ti-chi-bot ti-chi-bot mentioned this issue May 24, 2022
Merged
ti-chi-bot added a commit that referenced this issue May 25, 2022
@ti-chi-bot
codec(ticdc): update goavro to 2.11.1 to solve avro decimal encoding …
afe4104 
…bug (#5556) (#5579)

close #5554
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.1 area/ticdc Issues or PRs related to TiCDC. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

codec(ticdc): update goavro to 2.11.1 to solve avro decimal encoding bug zhangyangyu/tiflow
3 participants
@zhangyangyu @ti-chi-bot @nongfushanquan