Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdc cli changefeed admin operation blocked #1204

Closed
amyangfei opened this issue Dec 14, 2020 · 2 comments
Closed

cdc cli changefeed admin operation blocked #1204

amyangfei opened this issue Dec 14, 2020 · 2 comments
Assignees
Labels
area/ticdc Issues or PRs related to TiCDC. priority/P0 The issue has P0 priority. severity/critical type/bug The issue is confirmed as a bug.
Milestone

Comments

@amyangfei
Copy link
Contributor

amyangfei commented Dec 14, 2020

Bug Report

Please answer these questions before submitting your issue. Thanks!

  1. What did you do? If possible, provide a recipe for reproducing the error.

    Execute cdc cli changefeed remove -c xxx blocked.

  2. What did you expect to see?

    command runs successfully

  3. What did you see instead?

    20201214162858

    golang stack:
    owner.log

  4. Versions of the cluster

    • Upstream TiDB cluster version (execute SELECT tidb_version(); in a MySQL client):

      v4.0.7
      
    • TiCDC version (execute cdc version):

      v4.0.8
      
@amyangfei amyangfei added the type/bug The issue is confirmed as a bug. label Dec 14, 2020
@zier-one
Copy link
Contributor

zier-one commented Dec 14, 2020

Reproduce the bug:

#1205
Run integration tests in Github Action, we can reproduce this bug.

see goroutine.log here

@zier-one
Copy link
Contributor

zier-one commented Dec 17, 2020

fixed in tikv/pd#3283 and #1217

first, the PD client will be blocked in some cases, see tikv/pd#3283.
when a PD client is blocked, the whole StorageWithCurVersionCache will be blocked, and all pullers are frozen, like this:
image

and then, the owner will try to close the changefeed when a remove-changefeed command is received. however, all the pullers are frozen, the main goroutine of the owner will be blocked in closing the DDL puller, like the following picture:

image

@zier-one zier-one added this to the v4.0.9 milestone Dec 17, 2020
@AkiraXie AkiraXie added the area/ticdc Issues or PRs related to TiCDC. label Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ticdc Issues or PRs related to TiCDC. priority/P0 The issue has P0 priority. severity/critical type/bug The issue is confirmed as a bug.
Projects
None yet
Development

No branches or pull requests

4 participants