Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timestamp fill default value should also consider timezone #10931

Closed
3AceShowHand opened this issue Apr 19, 2024 · 0 comments · Fixed by #10932
Closed

timestamp fill default value should also consider timezone #10931

3AceShowHand opened this issue Apr 19, 2024 · 0 comments · Fixed by #10932
Assignees
@3AceShowHand
Labels
affects-6.5 affects-7.1 affects-7.5 affects-8.0 affects-8.1 area/ticdc Issues or PRs related to TiCDC. component/mounter Mounter component severity/moderate type/bug The issue is confirmed as a bug.

Comments

@3AceShowHand
Copy link
Contributor

3AceShowHand commented Apr 19, 2024 •
edited
Loading

#10803, we fix the default value that does not consider the data type.

Since TiDB stores the timestamp value in the UTC timezone, when filling the default value for the timezone type value, we should also convert the default value to the TiCDC specified timezone.
@3AceShowHand 3AceShowHand self-assigned this Apr 19, 2024
@3AceShowHand 3AceShowHand added type/enhancement The issue or PR belongs to an enhancement. area/ticdc Issues or PRs related to TiCDC. component/mounter Mounter component labels Apr 19, 2024
@3AceShowHand 3AceShowHand mentioned this issue Apr 19, 2024
Merged
@3AceShowHand 3AceShowHand added type/bug The issue is confirmed as a bug. severity/moderate affects-6.5 affects-7.1 affects-7.5 affects-8.0 and removed type/enhancement The issue or PR belongs to an enhancement. labels Apr 22, 2024
ti-chi-bot bot pushed a commit that referenced this issue Apr 23, 2024
@3AceShowHand
mounter(ticdc): timezone fill default value should also consider tz. (#…
e61d080 
…10932)

close #10931
This was referenced Apr 23, 2024
Merged
Merged
Merged
Open
Merged
ti-chi-bot bot pushed a commit that referenced this issue Apr 24, 2024
@ti-chi-bot
mounter(ticdc): timezone fill default value should also consider tz. (#…
26a6350 
…10932) (#10963)

close #10931
ti-chi-bot bot pushed a commit that referenced this issue Apr 26, 2024
@ti-chi-bot
mounter(ticdc): timezone fill default value should also consider tz. (#…
4757596 
…10932) (#10947)

close #10931
ti-chi-bot bot pushed a commit that referenced this issue Apr 26, 2024
@ti-chi-bot
mounter(ticdc): timezone fill default value should also consider tz. (#…
2d2748e 
…10932) (#10948)

close #10931
@asddongmen asddongmen mentioned this issue May 8, 2024
Closed
ti-chi-bot bot pushed a commit that referenced this issue Jun 5, 2024
@ti-chi-bot
mounter(ticdc): timezone fill default value should also consider tz. (#…
94b9897 
…10932) (#10946)

close #10931
hicqu added a commit to ti-chi-bot/tiflow that referenced this issue Jun 12, 2024
@hicqu
Squashed commit of the following:
a3d30ca 
commit c092599
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed Jun 12 00:26:59 2024 +0800

    pkg/config, sink(ticdc): support output raw change event for mq and cloud storage sink (pingcap#11226) (pingcap#11290)

    close pingcap#11211

commit 3426e46
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 19:40:29 2024 +0800

    puller(ticdc): fix wrong update splitting behavior after table scheduling (pingcap#11269) (pingcap#11282)

    close pingcap#11219

commit 2a28078
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 16:40:37 2024 +0800

    mysql(ticdc): remove error filter when check isTiDB in backend init (pingcap#11214) (pingcap#11261)

    close pingcap#11213

commit 2425d54
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 16:40:30 2024 +0800

    log(ticdc): Add more error query information to the returned error to facilitate users to know the cause of the failure (pingcap#10945) (pingcap#11257)

    close pingcap#11254

commit 053cdaf
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 15:34:30 2024 +0800

    cdc: log slow conflict detect every 60s (pingcap#11251) (pingcap#11287)

    close pingcap#11271

commit 327ba7b
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Tue Jun 11 11:42:00 2024 +0800

    redo(ticdc): return internal error in redo writer (pingcap#11011) (pingcap#11091)

    close pingcap#10124

commit d82ae89
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Mon Jun 10 22:28:29 2024 +0800

    ddl_puller (ticdc): handle dorp pk/uk ddl correctly (pingcap#10965) (pingcap#10981)

    close pingcap#10890

commit f15bec9
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Fri Jun 7 16:16:28 2024 +0800

    redo(ticdc): enable pprof and set memory limit for redo applier (pingcap#10904) (pingcap#10996)

    close pingcap#10900

commit ba50a0e
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed Jun 5 19:58:26 2024 +0800

    test(ticdc): enable sequence test (pingcap#11023) (pingcap#11037)

    close pingcap#11015

commit 94b9897
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed Jun 5 17:08:56 2024 +0800

    mounter(ticdc): timezone fill default value should also consider tz. (pingcap#10932) (pingcap#10946)

    close pingcap#10931

commit a912d33
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed Jun 5 10:49:25 2024 +0800

    mysql (ticdc): Improve the performance of the mysql sink by refining the transaction event batching logic (pingcap#10466) (pingcap#11242)

    close pingcap#11241

commit 6277d9a
Author: dongmen <20351731+asddongmen@users.noreply.github.com>
Date:   Wed May 29 20:13:22 2024 +0800

    kvClient (ticdc): revert e5999e3 to remove useless metrics (pingcap#11184)

    close pingcap#11073

commit 54e93ed
Author: dongmen <20351731+asddongmen@users.noreply.github.com>
Date:   Wed May 29 17:43:22 2024 +0800

    syncpoint (ticdc): make syncpoint support base64 encoded password (pingcap#11162)

    close pingcap#10516

commit 0ba9329
Author: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Date:   Wed May 29 09:07:21 2024 +0800

    (redo)ticdc: fix the event orderliness in redo log (pingcap#11117) (pingcap#11180)

    close pingcap#11096

Signed-off-by: qupeng <qupeng@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@3AceShowHand 3AceShowHand

Labels
affects-6.5 affects-7.1 affects-7.5 affects-8.0 affects-8.1 area/ticdc Issues or PRs related to TiCDC. component/mounter Mounter component severity/moderate type/bug The issue is confirmed as a bug.
Projects
Question and Bug Reports
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mounter(ticdc): timezone fill default value should also consider tz. 3AceShowHand/tiflow
1 participant
@3AceShowHand