Skip to content

Commit

Permalink
binlog-filter: log error instead of return it (#10380) (#10384)
Browse files Browse the repository at this point in the history
close #10282
  • Loading branch information
ti-chi-bot authored Feb 28, 2024
1 parent 083d8ca commit a7eb240
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion dm/tests/all_mode/conf/dm-task.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ filters: # filter rules, mysql instance can ref rules in it
user-filter-1:
schema-pattern: "*" # pattern of the upstream schema name, wildcard characters (*?) are supported
table-pattern: "*" # pattern of the upstream table name, wildcard characters (*?) are supported
events: ["truncate table", "drop table"] # ignore truncate/drop table ddl
events: ["truncate table", "drop table", "truncate"] # ignore truncate/drop table ddl
action: Ignore

mydumpers:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ require (
github.com/pingcap/kvproto v0.0.0-20231011074246-fa00d2b03372
github.com/pingcap/log v1.1.1-0.20230317032135-a0d097d16e22
github.com/pingcap/tidb v1.1.0-beta.0.20240226095130-a26af5fcf857
github.com/pingcap/tidb-tools v7.0.0+incompatible
github.com/pingcap/tidb-tools v7.0.1-0.20240226082442-627e9c95dcef+incompatible
github.com/pingcap/tidb/parser v0.0.0-20240226095130-a26af5fcf857
github.com/prometheus/client_golang v1.15.1
github.com/prometheus/client_model v0.3.0
Expand Down
4 changes: 2 additions & 2 deletions go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -931,8 +931,8 @@ github.com/pingcap/sysutil v1.0.1-0.20230407040306-fb007c5aff21/go.mod h1:QYnjfA
github.com/pingcap/tidb v1.1.0-beta.0.20220511160835-98c31070d958/go.mod h1:luW4sIZoLHY3bCWuKqyqk2QgMvF+/M7nWOXf/me0+fY=
github.com/pingcap/tidb v1.1.0-beta.0.20240226095130-a26af5fcf857 h1:ld1SpP9FY3T3/C7FltaWvLYvXtlDxPX4undufgGtmfY=
github.com/pingcap/tidb v1.1.0-beta.0.20240226095130-a26af5fcf857/go.mod h1:nlj98WnEyJVzA8JSQzfYGxBp7UaRMut2MMgrvFtN8sg=
github.com/pingcap/tidb-tools v7.0.0+incompatible h1:CHjAva2ON13HZAB0HRNI69fC/1AzfQBkzDE31Rh6NSg=
github.com/pingcap/tidb-tools v7.0.0+incompatible/go.mod h1:XGdcy9+yqlDSEMTpOXnwf3hiTeqrV6MN/u1se9N8yIM=
github.com/pingcap/tidb-tools v7.0.1-0.20240226082442-627e9c95dcef+incompatible h1:s1VZ+ozo6JwYui9aK6xLM9TUEaNNBeqDXS8Souru4vo=
github.com/pingcap/tidb-tools v7.0.1-0.20240226082442-627e9c95dcef+incompatible/go.mod h1:XGdcy9+yqlDSEMTpOXnwf3hiTeqrV6MN/u1se9N8yIM=
github.com/pingcap/tidb/parser v0.0.0-20211011031125-9b13dc409c5e/go.mod h1:e1MGCA9Sg3T8jid8PKAEq5eYVuMMCq4n8gJ+Kqp4Plg=
github.com/pingcap/tidb/parser v0.0.0-20220511160835-98c31070d958/go.mod h1:ElJiub4lRy6UZDb+0JHDkGEdr6aOli+ykhyej7VCLoI=
github.com/pingcap/tidb/parser v0.0.0-20221126021158-6b02a5d8ba7d/go.mod h1:ElJiub4lRy6UZDb+0JHDkGEdr6aOli+ykhyej7VCLoI=
Expand Down

0 comments on commit a7eb240

Please sign in to comment.