fix a data race

Signed-off-by: lance6716 <lance6716@gmail.com>
pingcap · Nov 4, 2022 · 9155f42 · 9155f42
1 parent fe27f1d
commit 9155f42
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/dm/config/task.go b/dm/config/task.go
@@ -22,6 +22,7 @@ import (
 	"sort"
 	"strconv"
 	"strings"
+	"sync"
 	"time"
 
 	"github.com/coreos/go-semver/semver"
@@ -1008,11 +1009,16 @@ func AdjustDBTimeZone(config *DBConfig, timeZone string) {
 	config.Session["time_zone"] = timeZone
 }
 
-var defaultParser = parser.New()
+var (
+	defaultParser = parser.New()
+	parserMu      sync.Mutex
+)
 
 func checkValidExpr(expr string) error {
 	expr = "select " + expr
+	parserMu.Lock()
 	_, _, err := defaultParser.Parse(expr, "", "")
+	parserMu.Unlock()
 	return err
 }