Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: remove session-ttl config from template #43

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

amyangfei
Copy link
Contributor

@amyangfei amyangfei commented Oct 19, 2022

What problem does this PR solve?

Issue link:

ref: pingcap/tiflow#7404

What is changed and how it works?

session-ttl is no longer used in tiflow, and remove it before pingcap/tiflow#7404 got merged is safe since it has a default value.

Code changes

  • Has Go code change
  • Has CI related scripts change

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Note for reviewer

@codecov-commenter
Copy link

Codecov Report

Base: 5.61% // Head: 5.61% // No change to project coverage 👍

Coverage data is based on head (596886f) compared to base (39e52a4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@          Coverage Diff           @@
##           master     #43   +/-   ##
======================================
  Coverage    5.61%   5.61%           
======================================
  Files          19      19           
  Lines        1905    1905           
======================================
  Hits          107     107           
  Misses       1785    1785           
  Partials       13      13           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu merged commit cfcfd4c into pingcap:master Oct 19, 2022
@amyangfei amyangfei deleted the remove-session-ttl-config branch October 19, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants