Skip to content

Improve the performance of min and max in window function #9953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Improve the performance of min and max in window function #9953

wants to merge 4 commits into from
+164 −153

Conversation

xzhangxian1008
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #9950

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Improve the performance of min and max in window function

@ti-chi-bot ti-chi-bot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 6, 2025
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker @guo-shaoge

@ti-chi-bot ti-chi-bot bot requested review from guo-shaoge and windtalker March 6, 2025 09:15
@xzhangxian1008
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 10, 2025
@xzhangxian1008
Copy link
Contributor Author

/cc @windtalker @guo-shaoge

windtalker
windtalker approved these changes Apr 11, 2025
View reviewed changes
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 11, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 11, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-11 08:48:07.535607477 +0000 UTC m=+2418981.219843568: ☑️ agreed by windtalker.

@xzhangxian1008
Copy link
Contributor Author

/cc @guo-shaoge

2 similar comments
@xzhangxian1008
Copy link
Contributor Author

/cc @guo-shaoge

@xzhangxian1008
Copy link
Contributor Author

/cc @guo-shaoge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windtalker windtalker windtalker approved these changes

@guo-shaoge guo-shaoge Awaiting requested review from guo-shaoge

Assignees
No one assigned
Labels
approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve the performance of min and max in window function
2 participants
@xzhangxian1008 @windtalker