Storages: support building vector index for ColumnFileTiny (Part 1) #9534
+424
−99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note-none
Lloyd-Pottiger
requested review from
breezewish,
JinheLin,
CalvinNeo and
JaySon-Huang
breezewish
approved these changes
Oct 16, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: breezewish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
Lloyd-Pottiger
force-pushed
the
cf-tiny-vector-index
branch
from
7f095b7
to
5136336
Compare
ti-chi-bot
bot
added
size/XXL
Lloyd-Pottiger
commented
Oct 16, 2024
breezewish
reviewed
Oct 16, 2024
CalvinNeo
reviewed
Oct 17, 2024
| auto new_index_infos = std::make_shared<IndexInfos>(); | ||
| for (const auto & index : *index_infos) | ||
| { | ||
| auto new_index_page_id = put_remote_page(index.index_page_id); |
There was a problem hiding this comment.
How to ensure that the page must exist?
There was a problem hiding this comment.
The workflow is
- write vector index (new page in log)
- delta update meta (new page in meta)
- page storage dump incremental checkpoint
So if new meta page was uploaded, the new log page must be uploaded.
| const auto & mem_table = delta->getMemTableSet(); | ||
| index_stats.rows_delta_not_indexed += mem_table->getRows(); | ||
| const auto & persisted = delta->getPersistedFileSet(); | ||
| for (const auto & file : persisted->getFiles()) |
There was a problem hiding this comment.
This for-loop maybe not thread-safe?
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
CalvinNeo
reviewed
Oct 18, 2024
| const CachePtr & cache_ = nullptr); | ||
|
|
||
| Type getType() const override { return Type::TINY_FILE; } | ||
|
|
||
| size_t getRows() const override { return rows; } | ||
| size_t getBytes() const override { return bytes; } | ||
|
|
||
| IndexInfosPtr getIndexInfos() const { return index_infos; } | ||
| bool hasIndex(Int64 index_id) const |
There was a problem hiding this comment.
hasIndex is better since we will support other types of index later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: ref #9032
Problem Summary:
What is changed and how it works?
This PR is part of https://github.com/tidbcloud/tiflash-cse/pull/293, which mainly adds index info in ColumnFileTiny meta.
Check List
Tests
Side effects
Documentation
Release note