-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: Fix rename come after database has been dropped (#9274) #9277
ddl: Fix rename come after database has been dropped (#9274) #9277
Conversation
/run-all-tests |
/run-unit-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CalvinNeo, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #9274
What problem does this PR solve?
Issue Number: close #9266
Problem Summary:
In
InterpreterRenameQuery
, it usecontext.getDatabase
which will throw an exception if the database instance is not exist in tiflash.The database has been dropped in TiDB before TiFlash sync the schema diff of "create database". And the following rename table to that database (database_id=170) throw exception.
What is changed and how it works?
In
SchemaBuilder::applyRenamePhysicalTable
it should create a local IDatabase instance with a "fake" DBInfo if can not fetch from TiKV.Check List
Tests
Side effects
Documentation
Release note