support selective block for MPPExchangeWriter #9195
Conversation
Signed-off-by: guo-shaoge <shaoge1994@163.com>
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
| size_t rows = 0; | ||
| if constexpr (selective_block) | ||
| { | ||
| RUNTIME_CHECK(block.info.selective && !block.info.selective->empty()); |
There was a problem hiding this comment.
why need to throw error if selective->empty() is true? Seems this function does not assume input block is not empty
There was a problem hiding this comment.
The next PR will make sure every block.info.selective is filled with data.
There was a problem hiding this comment.
but I think just check block.info.selective is enough?
There was a problem hiding this comment.
If block.info.selective->empty() is true, it means it's an empty block.
The code path shouldn't reach here.
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
Signed-off-by: guo-shaoge <shaoge1994@163.com>
ti-chi-bot
bot
added
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gengliqi, windtalker The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
What problem does this PR solve?
Issue Number: ref #9196
Problem Summary:
What is changed and how it works?
This is part of
auto pass through hashagg. We need selective block becauseAutoPassThroughBlockInputStreammay output selective block(only subset of rows are effective).IColumn::updateWeakHash32(),IColumn:scatter()andIColumn::scatterTo()FineGrainedWriterandHashPartitionWriterCheck List
Tests
Side effects
Documentation
Release note