-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storages: limit memory usage of data sharing (#8567) #8575
Merged
ti-chi-bot
merged 3 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-8567-to-release-7.5
Dec 25, 2023
Merged
Storages: limit memory usage of data sharing (#8567) #8575
ti-chi-bot
merged 3 commits into
pingcap:release-7.5
from
ti-chi-bot:cherry-pick-8567-to-release-7.5
Dec 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: JaySon <tshent@qq.com>
12 tasks
ti-chi-bot
added
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
labels
Dec 22, 2023
JinheLin
approved these changes
Dec 25, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Dec 25, 2023
Lloyd-Pottiger
approved these changes
Dec 25, 2023
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
labels
Dec 25, 2023
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
JaySon-Huang
approved these changes
Dec 25, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JaySon-Huang, JinheLin, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
added
the
cherry-pick-approved
Cherry pick PR approved by release team.
label
Dec 25, 2023
ti-chi-bot
bot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
and removed
do-not-merge/cherry-pick-not-approved
release-note-none
Denotes a PR that doesn't merit a release note.
labels
Dec 25, 2023
/run-unit-test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
cherry-pick-approved
Cherry pick PR approved by release team.
lgtm
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
type/cherry-pick-for-release-7.5
This PR is cherry-picked to release-7.5 from a source PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #8567
What problem does this PR solve?
Issue Number: close #8564
Problem Summary:
In terms of design, we hope that by scheduling tasks, the shared data will be immediately read and deleted, so under normal circumstances, it will not occupy additional memory.
However, there is a scenario that would break this assumption: If two requests A and B are merged, request A reads faster and request B reads slowly.
A will share the data with B, but request B may skip directly without reading and deleting these shared data, because it finds its queue is full (
tiflash/dbms/src/Storages/DeltaMerge/ReadThread/MergedTask.cpp
Lines 81 to 84 in 11c0567
What is changed and how it works?
This PR adds limitations on the size of shared data. It includes two aspects:
Check List
Tests
Side effects
Documentation
Release note