-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spill agg blocks using BlockInputStream #8040
spill agg blocks using BlockInputStream #8040
Conversation
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Others LGTM
} | ||
agg_spill_context->getSpiller()->spillBlocks(std::move(blocks), 0); | ||
auto block_input_stream = std::make_shared<AggHashTableToBlocksBlockInputStream<Method>>(*this, data_variants, method, max_temporary_block_size_rows, max_temporary_block_size_bytes); | ||
agg_spill_context->getSpiller()->spillBlocksUsingBlockInputStream(block_input_stream, 0, is_cancelled); | ||
agg_spill_context->finishOneSpill(thread_num); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe
auto [max_temporary_block_size_rows, max_temporary_block_size_bytes] = block_input_stream->maxBlockRowAndBytes();
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: SeaRise, yibin87 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/run-all-tests |
/rebuild |
Signed-off-by: xufei <xufeixw@mail.ustc.edu.cn>
/run-all-tests |
What problem does this PR solve?
Issue Number: ref #7738
Problem Summary:
What is changed and how it works?
spill aggregation data using
Spiller::spillBlocksUsingBlockInputStream
because it is more memory friendly.Check List
Tests
Side effects
Documentation
Release note