Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitor prehandle process #8036

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Monitor prehandle process #8036

wants to merge 3 commits into from
+36 −8

Conversation

CalvinNeo
Copy link
Member

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@CalvinNeo
s
d5144a7 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 28, 2023
@CalvinNeo
Copy link
Member Author

/run-build-release comment=true

@sre-bot
Copy link
Collaborator

sre-bot commented Aug 28, 2023

download tiflash binary(linux amd64) at http://fileserver.pingcap.net/download/builds/pingcap/test/tiflash/d5144a7f25f54418a2342716dca191b5ba7a5184/centos7/tiflash-linux-amd64.tar.gz

@CalvinNeo
d
2f6edbc 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 29, 2023
@CalvinNeo
d
79a7006 
Signed-off-by: CalvinNeo <calvinneo1995@gmail.com>
@CalvinNeo CalvinNeo changed the title dnm debug [DNM] Monitor prehandle process Aug 29, 2023
@CalvinNeo CalvinNeo changed the title [DNM] Monitor prehandle process Monitor prehandle process Aug 29, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 29, 2023

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/needs-linked-issue label, please provide the linked issue number on one line in the PR body, for example: Issue Number: close #123 or Issue Number: ref #456.

📖 For more info, you can check the "Contribute Code" section in the development guide.

CalvinNeo
CalvinNeo commented Aug 29, 2023
View reviewed changes
dbms/src/Storages/DeltaMerge/PKSquashingBlockInputStream.h
@@ -42,6 +43,15 @@ class PKSquashingBlockInputStream final : public IBlockInputStream
children.push_back(child);
}

~PKSquashingBlockInputStream() override
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aims to find out if there are too many rows in one block, thus cost too much time sorting

CalvinNeo
CalvinNeo commented Aug 29, 2023
View reviewed changes
dbms/src/Storages/DeltaMerge/SSTFilesToBlockInputStream.cpp
@@ -281,6 +282,17 @@ void SSTFilesToBlockInputStream::loadCFDataFromSST(
// Else continue to read next batch from current CF.
process_keys_offset_end += expected_size;
}
LOG_DEBUG(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It happens when there are barely no data in default/lock cf

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JinheLin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 29, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-29 10:13:52.988008155 +0000 UTC m=+1835597.537024142: ☑️ agreed by JinheLin.

@ti-chi-bot ti-chi-bot bot added the approved label Aug 29, 2023
@CalvinNeo
Copy link
Member Author

CalvinNeo commented Aug 31, 2023 •
edited
Loading

/hold batch with other improvements

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 31, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 17, 2023
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 17, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 26, 2024

@CalvinNeo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-test 79a7006 link true /test pull-integration-test
pull-unit-test 79a7006 link true /test pull-unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JinheLin JinheLin JinheLin approved these changes

@JaySon-Huang JaySon-Huang Awaiting requested review from JaySon-Huang

Assignees
No one assigned
Labels
approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/needs-linked-issue needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CalvinNeo @sre-bot @JinheLin