Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix potential receiver blocked in deconstruction #8020

Merged
merged 7 commits into from
Aug 25, 2023
Merged

Fix potential receiver blocked in deconstruction #8020

merged 7 commits into from
Aug 25, 2023

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Aug 25, 2023

What problem does this PR solve?

Issue Number: close #8019 ref #7177

Problem Summary:

  1. When ExchangeReceiverSet destruction, first close each receiver, then wait for all connection done.
  2. Delay local exchange receiver set destruction until handle error is done.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
    RandomFailpoint tests
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@yibin87
Avoid receiver blocking risk
7191c2c 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. labels Aug 25, 2023
@yibin87 yibin87 requested a review from SeaRise August 25, 2023 05:04
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 25, 2023
@yibin87
Little comment
dfc9efb 
Signed-off-by: yibin <huyibin@pingcap.com>
@yibin87
Fix format
c8ebebe 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 25, 2023
@yibin87
Copy link
Contributor Author

yibin87 commented Aug 25, 2023

/run-all-tests

@yibin87
Copy link
Contributor Author

yibin87 commented Aug 25, 2023

/run-integration-test

@yibin87
Copy link
Contributor Author

yibin87 commented Aug 25, 2023

/run-unit-test

xzhangxian1008
xzhangxian1008 approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@xzhangxian1008 xzhangxian1008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other LGTM

dbms/src/Flash/Mpp/MPPTask.cpp Outdated
}
catch (...)
{
std::unique_lock lock(mtx);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

std::lock_guard is better

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Aug 25, 2023
@yibin87
Copy link
Contributor Author

yibin87 commented Aug 25, 2023

/run-integration-test

@yibin87
Address comments
129992e 
Signed-off-by: yibin <huyibin@pingcap.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SeaRise, xzhangxian1008

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm approved and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Aug 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-25 05:57:07.320370071 +0000 UTC m=+1474591.869386043: ☑️ agreed by xzhangxian1008.
  • 2023-08-25 07:26:33.850038776 +0000 UTC m=+1479958.399054748: ☑️ agreed by SeaRise.

@yibin87
Copy link
Contributor Author

yibin87 commented Aug 25, 2023

/run-all-tests

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

@yibin87: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit e5fedf7 into pingcap:master Aug 25, 2023
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 25, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.4: #8024.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 25, 2023
@yibin87 @ti-chi-bot
This is an automated cherry-pick of pingcap#8020
1ec57e1 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.1: #8025.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 25, 2023
Closed
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 25, 2023
@yibin87 @ti-chi-bot
This is an automated cherry-pick of pingcap#8020
9d239aa 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #8026.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 25, 2023
Open
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 25, 2023
@yibin87 @ti-chi-bot
This is an automated cherry-pick of pingcap#8020
63d4be6 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8027.

@ti-chi-bot ti-chi-bot mentioned this pull request Aug 25, 2023
Closed
12 tasks
ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 25, 2023
@yibin87 @ti-chi-bot
This is an automated cherry-pick of pingcap#8020
df38911 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Aug 25, 2023
Closed
12 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-5.3: #8028.

ti-chi-bot pushed a commit to ti-chi-bot/tiflash that referenced this pull request Aug 25, 2023
@yibin87 @ti-chi-bot
This is an automated cherry-pick of pingcap#8020
fd29812 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzhangxian1008 xzhangxian1008 xzhangxian1008 approved these changes

@SeaRise SeaRise SeaRise approved these changes

@windtalker windtalker Awaiting requested review from windtalker

Assignees
No one assigned
Labels
approved lgtm needs-cherry-pick-release-5.3 Type: Need cherry pick to release-5.3 needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MPPTask blocked when destructing exchange receivers
4 participants
@yibin87 @ti-chi-bot @xzhangxian1008 @SeaRise