-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-enable clang-tidy check #7976
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
do-not-merge/needs-linked-issue
release-note-none
Denotes a PR that doesn't merit a release note.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
labels
Aug 18, 2023
JaySon-Huang
added
the
skip-issue-check
Indicates that a PR no need to check linked issue.
label
Aug 18, 2023
/rebuild |
Lloyd-Pottiger
approved these changes
Aug 18, 2023
ti-chi-bot
bot
added
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
approved
labels
Aug 18, 2023
hongyunyan
approved these changes
Aug 18, 2023
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hongyunyan, Lloyd-Pottiger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
Indicates a PR needs 1 more LGTM.
labels
Aug 18, 2023
[LGTM Timeline notifier]Timeline:
|
/run-all-tests |
ti-chi-bot
bot
added
needs-cherry-pick-release-6.1
Should cherry pick this PR to release-6.1 branch.
needs-cherry-pick-release-6.5
Should cherry pick this PR to release-6.5 branch.
needs-cherry-pick-release-7.1
Should cherry pick this PR to release-7.1 branch.
labels
Aug 18, 2023
JaySon-Huang
removed
needs-cherry-pick-release-6.1
Should cherry pick this PR to release-6.1 branch.
needs-cherry-pick-release-6.5
Should cherry pick this PR to release-6.5 branch.
needs-cherry-pick-release-7.1
Should cherry pick this PR to release-7.1 branch.
labels
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
lgtm
release-note-none
Denotes a PR that doesn't merit a release note.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
skip-issue-check
Indicates that a PR no need to check linked issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #7968
Problem Summary:
We disable the clang-tidy check in #7962 to make the CI passed, now we need to re-enable it for later changes.
What is changed and how it works?
Re-enable the clang-tidy checks
Check List
Tests
Side effects
Documentation
Release note