Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix the empty values when runtime filter is LOCAL mode #7794

Merged
merged 3 commits into from
Jul 12, 2023
Merged

[Bug] Fix the empty values when runtime filter is LOCAL mode #7794

merged 3 commits into from
Jul 12, 2023

Conversation

elsa0520
Copy link
Contributor

@elsa0520 elsa0520 commented Jul 11, 2023 •
edited
Loading

Fixed #7798

Closed pingcap/tidb#45300

This PR change the IN RS operator when values is empty. Using return RSResult::None instead of thrown exception when values is empty.

The In RS Operator is only used for runtime filter. When filter is empty (the build side is empty infact), the IN values will be empty. So this is not a exception and it should skip all of scan of packs.

What problem does this PR solve?

Issue Number: close #7798

Problem Summary:

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@elsa0520
[Bug] Fix the empty values when runtime filter is LOCAL mode
b014e21 
Fixed pingcap/tidb#45300

This PR change the IN RS operator when values is empty.
Using return RSResult::None instead of thrown exception when values is empty.

The In RS Operator is only used for runtime filter.
When filter is empty (the build side is empty infact), the IN values will be empty.
So this is not a exception and it should skip all of scan of packs.
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 11, 2023
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/needs-triage-completed labels Jul 11, 2023
@elsa0520
Copy link
Contributor Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Jul 11, 2023
@Lloyd-Pottiger
Copy link
Contributor

/run-unit-test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

@winoros: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 11, 2023

@AilinKid: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AilinKid, hongyunyan, Lloyd-Pottiger, winoros

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Lloyd-Pottiger,hongyunyan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 12, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 12, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-07-11 12:58:38.213455694 +0000 UTC m=+423209.983794407: ☑️ agreed by Lloyd-Pottiger.
  • 2023-07-12 06:18:13.070505451 +0000 UTC m=+485584.840844165: ☑️ agreed by hongyunyan.

@elsa0520
Copy link
Contributor Author

/merge

@elsa0520
Copy link
Contributor Author

/run-all-tests

@elsa0520
Copy link
Contributor Author

/run-unit-test

@SeaRise
Copy link
Contributor

SeaRise commented Jul 12, 2023

/run-unit-test

1 similar comment
@SeaRise
Copy link
Contributor

SeaRise commented Jul 12, 2023

/run-unit-test

@ti-chi-bot ti-chi-bot bot merged commit 8404eb7 into pingcap:master Jul 12, 2023
@elsa0520 elsa0520 mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winoros winoros winoros approved these changes

@AilinKid AilinKid AilinKid approved these changes

@hongyunyan hongyunyan hongyunyan approved these changes

@Lloyd-Pottiger Lloyd-Pottiger Lloyd-Pottiger approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
6 participants
@elsa0520 @Lloyd-Pottiger @SeaRise @winoros @AilinKid @hongyunyan