Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pipeline: support join without spill #7333

Merged
merged 20 commits into from
Apr 23, 2023
Merged

Pipeline: support join without spill #7333

merged 20 commits into from
Apr 23, 2023

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Apr 21, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6518

Problem Summary:

What is changed and how it works?

  • spilt gtest_join_executor.cpp to gtest_join_executor.cpp and gtest_spill_join.cpp.
  • Modify the definition of fine grained mode pipeline as For fine grained mode, all plan node should enable fine grained shuffle.
  • support Join in pipeline model, but spill is still not supported.

Check List

Tests

gtest_join_executor.cpp tsan passed.

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Apr 21, 2023 •
edited by ti-chi-bot bot
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • yibin87
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 21, 2023
@SeaRise SeaRise changed the title New support join in pipeline Pipeline: support join in pipeline Apr 21, 2023
@SeaRise SeaRise changed the title Pipeline: support join in pipeline Pipeline: support join without spill Apr 21, 2023
@ywqzzy ywqzzy self-requested a review April 21, 2023 10:43
@SeaRise SeaRise changed the title Pipeline: support join without spill WIP: Pipeline: support join without spill Apr 21, 2023
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 21, 2023
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Apr 23, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 23, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 23, 2023

/run-integration-test

@SeaRise SeaRise mentioned this pull request Apr 23, 2023
Closed
25 tasks
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 23, 2023

/run-integration-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 23, 2023

/run-unit-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 23, 2023

/run-unit-test

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 23, 2023

/run-integration-test

@SeaRise SeaRise changed the title WIP: Pipeline: support join without spill Pipeline: support join without spill Apr 23, 2023
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 23, 2023

/run-all-tests

@SeaRise SeaRise requested a review from ywqzzy April 23, 2023 06:19
@ywqzzy ywqzzy self-requested a review April 23, 2023 06:21
@SeaRise @ywqzzy
Update dbms/src/Flash/Planner/PlanType.h
8b1f390 
Co-authored-by: EasonBall <592838129@qq.com>
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 23, 2023
@SeaRise SeaRise requested a review from yibin87 April 23, 2023 07:34
yibin87
yibin87 approved these changes Apr 23, 2023
View reviewed changes
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 23, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 23, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2023

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 8b1f390

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 23, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Apr 23, 2023

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sre-bot
Copy link
Collaborator

sre-bot commented Apr 23, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 23, 2023

/run-integration-test

1 similar comment
@SeaRise
Copy link
Contributor Author

SeaRise commented Apr 23, 2023

/run-integration-test

@ti-chi-bot ti-chi-bot bot merged commit 0f7603a into pingcap:master Apr 23, 2023
@SeaRise SeaRise deleted the new_support_join_in_pipeline branch April 23, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yibin87 yibin87 yibin87 approved these changes

@ywqzzy ywqzzy ywqzzy approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@SeaRise @ti-chi-bot @sre-bot @yibin87 @ywqzzy