-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pipeline: support spill for fine grained aggregation #7220
Merged
ti-chi-bot
merged 36 commits into
pingcap:master
from
SeaRise:pipeline_support_spill_agg
Apr 20, 2023
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
41b44d3
pre modify
SeaRise 96c4b01
update
SeaRise 4d39f1d
fix ut
SeaRise 7f73b05
update
SeaRise bc17c52
fix comment
SeaRise 0398d35
add more comment
SeaRise 67a7e46
use executeIO
SeaRise ea6b4b3
fix tidy
SeaRise 7ae7753
Merge branch 'master' into support_io_cpu_thread_pool
SeaRise bdc0e6f
Update dbms/src/Flash/Pipeline/Exec/PipelineExec.cpp
SeaRise 00ec7a0
pre refine
SeaRise c29f0a6
refine
SeaRise 07f7f5d
u
SeaRise 62972fa
update
SeaRise 8105719
add more comments
SeaRise 4b1aeb0
add ut and fix
SeaRise b676835
u
SeaRise 4985799
Merge branch 'master' into pipeline_support_spill_agg
SeaRise 787467e
u
SeaRise 90f4842
u
SeaRise 9b6ea2e
Merge branch 'master' into pipeline_support_spill_agg
SeaRise c3aff6d
Merge branch 'master' into pipeline_support_spill_agg
SeaRise 518aee8
merge master
SeaRise 49aab93
add comments
SeaRise 2b9eddf
Merge branch 'master' into pipeline_support_spill_agg
SeaRise 2c111d5
fix typo
SeaRise f032df2
Merge branch 'master' into pipeline_support_spill_agg
SeaRise fc13949
minor refine
SeaRise 849892a
Merge branch 'master' into pipeline_support_spill_agg
SeaRise 4f8da9c
refine comments
SeaRise 3753242
address comments
SeaRise 36be5a0
add more comments
SeaRise 9f042ef
check not empty
SeaRise 68bacca
port from #7318
SeaRise 3d49d23
Merge branch 'master' into pipeline_support_spill_agg
Lloyd-Pottiger 7b0b566
fix clang tidy
SeaRise File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we need to delete these codes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic of
AggContext::useNullSource
is wrapped intoAggContext::getConvergentConcurrency
andAggContext::readForConvergent
, just to simplify the code.