Fix evicting files of file cache.

[JinheLin]

What problem does this PR solve?

Issue Number: close #6827

• First problem:

  • When evicting files, we need to traverse the LRU queue and delete files that are not held by other threads.
  • If the deletion is successful, we need to use the iterator returned by the deletion function since the current iterator is deleted and invalid.
  • If the deletion fails, the current iterator is used to continue the iteration.
  • The problem is that the current implementation thinks that when the returned free space is 0, it is a deletion failure. But in fact, if we are deleting an empty file, the return of 0 may also be a deletion success, leading to the invalidation of the iterator.
  • FIXED: return -1 when deletion fails.

• Second problem:

  • FileTable::get will update LRU queue when traversing the LRU queue and getting file from FileTable and causing inaccurate traversal.
  • FIXED: not update LRU queue when traversing.

• Third problem:

  • std::filesystem::file_size throws exception if file does not exist.
  • FIXED: check file exists at the beginning.

What is changed and how it works?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

None

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• Lloyd-Pottiger
• flowbehappy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[JinheLin]

/run-all-tests

[JinheLin]

/run-integration-test

[Lloyd-Pottiger]

Others LGTM

[JinheLin]

/merge

[ti-chi-bot]

@JinheLin: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: cba055a

[breezewish]

Verified no more crash in test env for now.

[ti-chi-bot]

@JinheLin: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.