Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline: support fine grained shuffle #6934

Merged

Conversation

SeaRise
Copy link
Contributor

@SeaRise SeaRise commented Mar 2, 2023

What problem does this PR solve?

Issue Number: ref #6518

Problem Summary:

What is changed and how it works?

  • refine void buildPipelineExec(PipelineExecGroupBuilder & group_builder, Context & context, size_t concurrency); to void buildPipelineExec(PipelineExecutorStatus & exec_status, PipelineExecGroupBuilder & group_builder, Context & context, size_t concurrency); and PipelineExecGroupBuilder no longer held PipelineExecutorStatus.
  • Add function getFineGrainedShuffle of PhysicalPlanNode and then Pipeline will use this function to determine whether the execution mode is fine-grained or non-fine-grained.
  • Add FineGrainedPipelineEvent to support fine grained execution mode and remove useless PipelineEvent.
 *        ┌──non fine grained mode──┐                          ┌──fine grained mode──┐
 *                                            ┌──FineGrainedPipelineEvent◄───FineGrainedPipelineEvent
 * PlainPipelineEvent◄───PlainPipelineEvent◄──┼──FineGrainedPipelineEvent◄───FineGrainedPipelineEvent
 *                                            ├──FineGrainedPipelineEvent◄───FineGrainedPipelineEvent
 *                                            └──FineGrainedPipelineEvent◄───FineGrainedPipelineEvent
  • support fine grained shuffle in exchange receiver/sender.
  • add fullstack test for pipeline mode

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Mar 2, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • yibin87
  • ywqzzy

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Mar 2, 2023
@SeaRise SeaRise mentioned this pull request Mar 2, 2023
25 tasks
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 2, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 2, 2023

/run-all-tests

@SeaRise SeaRise changed the title Pipeline: Support fine grained shuffle Pipeline: support fine grained shuffle Mar 2, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 2, 2023

/hold

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 3, 2023

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 3, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 3, 2023

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 14, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 14, 2023

/run-all-tests

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 14, 2023

/rebuild

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 14, 2023

/run-integration-test

1 similar comment
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 14, 2023

/run-integration-test

@SeaRise SeaRise requested a review from yibin87 March 15, 2023 15:42
Copy link
Contributor

@yibin87 yibin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, better merge it after code freeze:)

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Mar 16, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 16, 2023

LGTM, better merge it after code freeze:)

Okay

@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 16, 2023

/hold
merge after code freeze

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 16, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 20, 2023

/hold cancel

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 20, 2023
@SeaRise
Copy link
Contributor Author

SeaRise commented Mar 20, 2023

/merge

@ti-chi-bot
Copy link
Member

@SeaRise: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4ae0cc5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Mar 20, 2023
@ti-chi-bot
Copy link
Member

@SeaRise: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

trigger some heavy tests which will not run always when PR updated.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit ac240b4 into pingcap:master Mar 20, 2023
@SeaRise SeaRise deleted the support_fine_grained_shuffle_for_pipeline branch March 20, 2023 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants